Attention is currently required from: Furquan Shaikh, Maulik V Vaghela.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55348 )
Change subject: mb/google/brya: Update mainboard properties for BB retimer upgrade
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55348/comment/7c3a7420_cf630d38
PS9, Line 146: [1] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4),
: .group = ACPI_PLD_GROUP(3, 1),}}"
should this be under tcss_dma1 ? this is for Type-C Port 3... but then we've got two driver instances in the kernel probably thinking they both have exclusive access to this GPIO......
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24a02fd446cb66bda9e66e59802b4deea6894273
Gerrit-Change-Number: 55348
Gerrit-PatchSet: 9
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: John Zhao
john.zhao@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Tue, 15 Jun 2021 17:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment