Attention is currently required from: Julius Werner, Kyösti Mälkki, Alexander Couzens, Aaron Durbin, Patrick Rudolph.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50040 )
Change subject: {src}: Assign values before if statement
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
You most likely will be requested to split all that x86emu whitespace change to different commit.
During update something went wrong.
This patch should be placed on CB:50123
Patchset:
PS3:
This isn't actually a requirement of our Coding Style, and I would vote against making it one. […]
I was not aware of history of checkpatch.
Goal is cleaning checkpatch output.
Disabling ASSIGN_IN_IF is a 'solution, but having a consistent code style is another way of solving this issue.
The 'issue' occures in a few files only!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd346d31f1da71271ad1545e5645e57530c7b374
Gerrit-Change-Number: 50040
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Feb 2021 07:17:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment