Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58400 )
Change subject: kconfig_lint: put $inside_choice together right in the first place ......................................................................
kconfig_lint: put $inside_choice together right in the first place
Instead of substituting the delimiter later, put $inside_choice together right in the first place.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Ia713510a683101c48c86a1c3722ebb1607a29288 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58400 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/lint/kconfig_lint 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 76dd787..9e2c207 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -614,7 +614,7 @@ $choice_symbol = $symbol; } $inside_config = ""; - $inside_choice = "$filename $line_no"; + $inside_choice = "$filename:$line_no"; $configs_inside_choice = 0;
# Kconfig verifies that choice blocks have a prompt @@ -806,7 +806,7 @@ $symbols{$symbol}{choice} = 1;
# remember the location of the choice - $symbols{$symbol}{choice_loc} = join(':', (split / /, $inside_choice)); + $symbols{$symbol}{choice_loc} = $inside_choice; } else { $symbols{$symbol}{choice} = 0;