Attention is currently required from: Martin Roth, Furquan Shaikh, Kangheui Won, Bhanu Prakash Maiya, Isaac Lee, Marco Chen, Zhuohao Lee, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51053 )
Change subject: mb/google/zork/vilboz: Enable ALC1015 AMP driver
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/51053/comment/d02f575b_c4e7dc5f
PS5, Line 90: int variant_gets_audio_amp_type_config(void)
Not quite sure what is the intention for adding this.
Done
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51053/comment/291c45a1_6812902d
PS5, Line 6: option AUDIO_AMP_I2C_MODE 0
Agree, i also think putting the index 0 as the first item would be better.
Done
https://review.coreboot.org/c/coreboot/+/51053/comment/cd3ed000_9b8fbaed
PS5, Line 217: 0.1
This will confusing the "fw config probe" function. We use 0.0 for AMDI1015.
Thanks for the explanation from Eric.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51053
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0abfd6570579fe637a7bef31de2f01d58f3bdf6
Gerrit-Change-Number: 51053
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Wed, 24 Mar 2021 03:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment