Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44559 )
Change subject: mb/google/volteer: Update SLP_Sx assertion widths and PwrCycDur ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 152: 3
Tim, with current common code implementation, I think this definition cannot be used directly here t […]
Ah right, it was on my to-do list to move those to a header file. Sorry.
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 153: 1
Same as above.
Ack
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 154: 3
Same as above.
Ack
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 155: 3
Same as above.
Ack