Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO [WIP]

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [WIP]...

Maxim Polyakov (Code Review)

31 Mar 2020 31 Mar '20

12:23 p.m.

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39987 )

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO [WIP] ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO [WIP]

Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/tiogapass/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/1

diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl index 9d33865..59ee7f8 100644 --- a/src/mainboard/ocp/tiogapass/dsdt.asl +++ b/src/mainboard/ocp/tiogapass/dsdt.asl @@ -35,5 +35,7 @@ // Xeon-SP ACPI tables Scope (_SB) { #include <soc/intel/xeon_sp/skx/acpi/uncore.asl> + #include <soc/intel/common/acpi/pcr.asl> + #include <soc/intel/xeon_sp/acpi/gpio.asl> } }

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Maxim Polyakov (Code Review)

31 Mar 31 Mar

2:12 p.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#3).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/3

Maxim Polyakov (Code Review)

7 Apr 7 Apr

6:39 a.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#10).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 10 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Maxim Polyakov (Code Review)

12 Apr 12 Apr

1:53 p.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#18).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 18 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Maxim Polyakov (Code Review)

26 Apr 26 Apr

12:09 p.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#24).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/24

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 24 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Maxim Polyakov (Code Review)

27 Apr 27 Apr

11:21 a.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#26).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/26

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 26 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Maxim Polyakov (Code Review)

1 May 1 May

3:05 p.m.

New subject: Change in coreboot[master]: mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#33).

Change subject: mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

mb/ocp/tiogapass: use ACPI to control GPIO

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/33

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 33 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Maxim Polyakov (Code Review)

27 Sep 27 Sep

5:43 a.m.

New subject: Change in coreboot[master]: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Hello build bot (Jenkins), Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39987

to look at the new patch set (#34).

Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

[WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/tiogapass/dsdt.asl 1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39987/34

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 34 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Marc Jones (Code Review)

28 Sep 28 Sep

10:15 p.m.

New subject: Change in coreboot[master]: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39987 )

Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

Patch Set 34:

I have some changes coming that might be helpful. This asl code should go in the xeon_sp/acpi/pch.asl. It isn't specific to the mainboard.

I plan to push changes tomorrow. I'll add you to the reviews.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 34 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Sep 2020 05:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marc Jones (Code Review)

9 Nov 9 Nov

9:13 a.m.

New subject: Change in coreboot[master]: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39987 )

Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

Patch Set 35:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas... PS35, Line 23: #include <soc/intel/xeon_sp/acpi/gpio.asl> This should be added to xeon_sp/acpi/pch.asl

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 35 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Nov 2020 17:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

16 Nov 16 Nov

2:14 p.m.

New subject: Change in coreboot[master]: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39987 )

Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

Patch Set 35:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas... PS35, Line 23: #include <soc/intel/xeon_sp/acpi/gpio.asl>

...

This should be added to xeon_sp/acpi/pch. […]

https://review.coreboot.org/c/coreboot/+/39979

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 35 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Nov 2020 22:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marc Jones marc@marcjonesconsulting.com Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

2:15 p.m.

New subject: Change in coreboot[master]: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO

Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39987 )

Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/39987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b Gerrit-Change-Number: 39987 Gerrit-PatchSet: 35 Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1463

days inactive

1693

days old

coreboot-gerrit@coreboot.org

11 comments

2 participants

tags (0)

participants (2)

Marc Jones (Code Review)
Maxim Polyakov (Code Review)