Change in coreboot[master]: Revert "mb/google/dedede: Update Imon slope and Offset Value for Draw...
Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia"
Falling back to default values for Imon slope and offset for Drawcia This is as per recommendation from ODM based on calibration
This reverts commit 2ac88f2347352c5dff0af18d5130dbdd6f032930.
BUG=None BRANCH=dedede TEST=Debug FSP confirms that values are reverted to default
Change-Id: I605acdcd0de2c5dfc28af2aea8cefc6b629c0925 --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/48737/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 493854c..e09dbe8 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -63,8 +63,6 @@ }"
register "tcc_offset" = "20" # TCC of 85C - register "ImonOffset" = "1400" # Imon Offset = 1.4 - register "ImonSlope" = "100" # Imon Slope = 1.0
# Enable Acoustic noise mitigation and set slew rate to 1/4 # Rest of the parameters are 0 by default.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48737/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48737/1//COMMIT_MSG@14 PS1, Line 14: None Add bug id
Hello build bot (Jenkins), Rizwan Qureshi, Sumeet R Pawnikar, Meera Ravindranath, Ronak Kanabar, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48737
to look at the new patch set (#2).
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia"
Falling back to default values for Imon slope and offset for Drawcia This is as per recommendation from ODM based on calibration
This reverts commit 2ac88f2347352c5dff0af18d5130dbdd6f032930.
BUG=None BRANCH=dedede TEST=Debug FSP confirms that values are reverted to default
Change-Id: I605acdcd0de2c5dfc28af2aea8cefc6b629c0925 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/48737/2
Hello build bot (Jenkins), Rizwan Qureshi, Sumeet R Pawnikar, Meera Ravindranath, Ronak Kanabar, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48737
to look at the new patch set (#3).
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia"
Falling back to default values for Imon slope and offset for Drawcia This is as per recommendation from ODM based on calibration
This reverts commit 2ac88f2347352c5dff0af18d5130dbdd6f032930.
BUG=b:175629526 BRANCH=dedede TEST=Debug FSP confirms that values are reverted to default
Change-Id: I605acdcd0de2c5dfc28af2aea8cefc6b629c0925 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/48737/3
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48737/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48737/1//COMMIT_MSG@14 PS1, Line 14: None
Add bug id
Done
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Patch Set 3: Code-Review+2
Vidya Gopalakrishnan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Patch Set 3: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Patch Set 3: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48737 )
Change subject: Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia" ......................................................................
Revert "mb/google/dedede: Update Imon slope and Offset Value for Drawcia"
Falling back to default values for Imon slope and offset for Drawcia This is as per recommendation from ODM based on calibration
This reverts commit 2ac88f2347352c5dff0af18d5130dbdd6f032930.
BUG=b:175629526 BRANCH=dedede TEST=Debug FSP confirms that values are reverted to default
Change-Id: I605acdcd0de2c5dfc28af2aea8cefc6b629c0925 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48737 Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Reviewed-by: Vidya Gopalakrishnan vidya.gopalakrishnan@intel.corp-partner.google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Vidya Gopalakrishnan: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 493854c..e09dbe8 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -63,8 +63,6 @@ }"
register "tcc_offset" = "20" # TCC of 85C - register "ImonOffset" = "1400" # Imon Offset = 1.4 - register "ImonSlope" = "100" # Imon Slope = 1.0
# Enable Acoustic noise mitigation and set slew rate to 1/4 # Rest of the parameters are 0 by default.
-
Hung-Te Lin (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Vidya Gopalakrishnan (Code Review)