Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: src/mainboard/libretrend/lt1000: Initial commit ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... File src/mainboard/libretrend/lt1000/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... PS8, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2018 Libretrend LDA : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ : Remove? There's nothing in the file to copyright or license.
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... File src/mainboard/libretrend/lt1000/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... PS8, Line 1: /* Again, remove the header since there's nothing to copyright or license.
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... File src/mainboard/libretrend/lt1000/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... PS8, Line 36: defautl default
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... File src/mainboard/libretrend/lt1000/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/30360/8/src/mainboard/libretrend/lt... PS8, Line 43: nit: extra line
-
Martin Roth (Code Review)