Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78895?usp=email )
Change subject: soc/amd/genoa: Add mmio.asl
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
unrelated to this patch, but it seems that the genoa patches are missing the i2c support enablement on the coreboot side
File src/soc/amd/genoa/acpi/mmio.asl:
https://review.coreboot.org/c/coreboot/+/78895/comment/c2ec8903_9f29ca35 :
PS1, Line 282: #if CONFIG(SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP)
this doesn't apply for genoa, since genoa won't have verstage on psp. same below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78895?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5bc2cc0141e9da7e2c6ed7691188d7c94b6b1e3
Gerrit-Change-Number: 78895
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 03 Nov 2023 15:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment