Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69800 )
Change subject: security: Remove unnecessary space after casts ......................................................................
security: Remove unnecessary space after casts
Change-Id: Ibd41382d0e0ef58498ac925dc9e10b54a76a798a Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/security/intel/stm/StmPlatformSmm.c M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/vboot/vbnv.c 4 files changed, 22 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69800/1
diff --git a/src/security/intel/stm/StmPlatformSmm.c b/src/security/intel/stm/StmPlatformSmm.c index bcf935c..e5b3cf1 100644 --- a/src/security/intel/stm/StmPlatformSmm.c +++ b/src/security/intel/stm/StmPlatformSmm.c @@ -85,7 +85,7 @@
TXT_PROCESSOR_SMM_DESCRIPTOR *psd;
- smbase_processor = (void *) SMM_DEFAULT_BASE;//we are here + smbase_processor = (void *)SMM_DEFAULT_BASE;//we are here psd = smbase + SMM_PSD_OFFSET;
printk(BIOS_DEBUG, @@ -121,8 +121,8 @@
read_gdtr(&gdtr);
- gdtr.base -= (uintptr_t) smbase_processor; - gdtr.base += (uintptr_t) smbase; + gdtr.base -= (uintptr_t)smbase_processor; + gdtr.base += (uintptr_t)smbase;
psd->smm_gdt_ptr = gdtr.base; psd->smm_gdt_size = gdtr.limit + 1; // the stm will subtract, so add @@ -159,7 +159,7 @@ // some processor to receive a bad value // calculate the location in SMRAM addr_calc = mseg - CONFIG_BIOS_RESOURCE_LIST_SIZE; - stm_resource_heap = (uint8_t *) addr_calc; + stm_resource_heap = (uint8_t *)addr_calc;
if (cpu == 0) {
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 6b79aab..39c44ec 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -51,7 +51,7 @@ { uint32_t size; from_tpm_uint32(buffer + sizeof(uint16_t), &size); - return (int) size; + return (int)size; }
/* Gets the code field of a TPM command. */ diff --git a/src/security/tpm/tss/tcg-1.2/tss_structures.h b/src/security/tpm/tss/tcg-1.2/tss_structures.h index 4a976c8..689bb4b 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_structures.h +++ b/src/security/tpm/tss/tcg-1.2/tss_structures.h @@ -21,13 +21,13 @@ #define TPM_NV_PER_READ_STCLEAR (((uint32_t)1)<<31) #define TPM_NV_PER_WRITE_STCLEAR (((uint32_t)1)<<14)
-#define TPM_TAG_RQU_COMMAND ((uint16_t) 0xc1) -#define TPM_TAG_RQU_AUTH1_COMMAND ((uint16_t) 0xc2) -#define TPM_TAG_RQU_AUTH2_COMMAND ((uint16_t) 0xc3) +#define TPM_TAG_RQU_COMMAND ((uint16_t)0xc1) +#define TPM_TAG_RQU_AUTH1_COMMAND ((uint16_t)0xc2) +#define TPM_TAG_RQU_AUTH2_COMMAND ((uint16_t)0xc3)
-#define TPM_TAG_RSP_COMMAND ((uint16_t) 0xc4) -#define TPM_TAG_RSP_AUTH1_COMMAND ((uint16_t) 0xc5) -#define TPM_TAG_RSP_AUTH2_COMMAND ((uint16_t) 0xc6) +#define TPM_TAG_RSP_COMMAND ((uint16_t)0xc4) +#define TPM_TAG_RSP_AUTH1_COMMAND ((uint16_t)0xc5) +#define TPM_TAG_RSP_AUTH2_COMMAND ((uint16_t)0xc6)
typedef uint8_t TSS_BOOL; typedef uint16_t TPM_STRUCTURE_TAG; diff --git a/src/security/vboot/vbnv.c b/src/security/vboot/vbnv.c index 26946fd..e9223c0 100644 --- a/src/security/vboot/vbnv.c +++ b/src/security/vboot/vbnv.c @@ -24,7 +24,7 @@ } }
- return (uint8_t) (crc >> 8); + return (uint8_t)(crc >> 8); }
void vbnv_reset(uint8_t *vbnv_copy)