Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz This chan...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Johnny Li (Code Review)

7 Oct 2020 7 Oct '20

11:28 a.m.

Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. ......................................................................

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz. Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/1

diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 2ef9fc9..d39f3ab 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -32,7 +32,13 @@ }, .i2c[3] = { .speed = I2C_SPEED_FAST, - }, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 153, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, .i2c[5] = { .speed = I2C_SPEED_FAST, .speed_config[0] = {

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

7 Oct 7 Oct

11:29 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46127/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46127/1/src/mainboard/google/voltee... PS1, Line 39: .sda_hold = 36, trailing whitespace

Johnny Li (Code Review)

11:32 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#2).

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/2

Johnny Li (Code Review)

11:38 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#3).

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/3

Johnny Li (Code Review)

11:39 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#4).

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/4

Johnny Li (Code Review)

11:42 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#5).

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:153588771

TEST=Verified that I2C5 frequency is between 389-396kHz. Signed-off-by:Johnny Lijohnny_li@wistron.corp-partner.google.com Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/5

Johnny Li (Code Review)

11:47 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#6).

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:153588771

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/6

Johnny Li (Code Review)

11:48 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Patch Set 6: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 6 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 07 Oct 2020 09:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Caveh Jalali (Code Review)

12:44 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Patch Set 6:

volteer is the old ES2 board, did you mean to apply this to volteer2 (QS onward)? looks like we still need to add the common_soc_config section to the volteer2/overridetree.cb.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 6 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 07 Oct 2020 10:44:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

8 Oct 8 Oct

2:21 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46127

to look at the new patch set (#7).

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.

BUG=b:153588771

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/46127/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

2:37 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Patch Set 7:

...

Patch Set 6:

volteer is the old ES2 board, did you mean to apply this to volteer2 (QS onward)? looks like we still need to add the common_soc_config section to the volteer2/overridetree.cb.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Comment-Date: Thu, 08 Oct 2020 00:37:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

2:46 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-MessageType: abandon

Johnny Li (Code Review)

13 Oct 13 Oct

5:23 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Johnny Li has restored this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-MessageType: restore

Johnny Li (Code Review)

5:23 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz

Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46127 )

Change subject: mb/google/volteer/var/volteer: I2C5 Camera bus freq 400 kHz ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6cd8ec1241925a3426bf51665cadcb55435dede Gerrit-Change-Number: 46127 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-MessageType: abandon

1556

days inactive

1562

days old

coreboot-gerrit@coreboot.org

13 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Caveh Jalali (Code Review)
Johnny Li (Code Review)