Attention is currently required from: Patrick Rudolph, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: device/device_util: Add method to retrieve the domain ......................................................................
Patch Set 1:
(2 comments)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/80090/comment/c44e5068_7c3dcda0 : PS1, Line 267: while (dev->bus) { The root device is identified by `dev == dev->bus->dev`. So the cannonical way to walk up is ``` for (dev = dev->bus->dev; dev != dev->bus->dev; dev = dev->bus->dev) ``` This has come up more often lately, so we should probably add an inline is_root() for this. To make the code more self explaining. Let me know if you'd prefer (me) to add that later.
https://review.coreboot.org/c/coreboot/+/80090/comment/e75956a9_89c9fe50 : PS1, Line 269: if (!dev) This should never be the case and shouldn't be ignored. An assert() would be suitable I guess.