Attention is currently required from: Patrick Rudolph, Shuo Liu.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
2 comments:
File src/device/device_util.c:
Patch Set #1, Line 267: while (dev->bus) {
The root device is identified by `dev == dev->bus->dev`. So the cannonical
way to walk up is
```
for (dev = dev->bus->dev; dev != dev->bus->dev; dev = dev->bus->dev)
```
This has come up more often lately, so we should probably add an inline
is_root() for this. To make the code more self explaining. Let me know
if you'd prefer (me) to add that later.
Patch Set #1, Line 269: if (!dev)
This should never be the case and shouldn't be ignored. An assert() would
be suitable I guess.
To view, visit change 80090. To unsubscribe, or for help writing mail filters, visit settings.