Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 40:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/25362783_31df4eb9 PS40, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/6460b333_3977d63e PS40, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/a315b3f3_b3ed6e61 PS40, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/f68e98b9_32a1265f PS40, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/37878260_134ad58a PS40, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/f516dbfb_352180df PS40, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/5ddc99aa_40d33c82 PS40, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/471c0787_6008a51b PS40, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/ddde5d34_95bf72e3 PS40, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/12f3f5de_dd4ab461 PS40, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/604978f6_6cf9b967 PS40, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/70b87e09_e49fc6d5 PS40, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/a03ffb07_6e4f5da6 PS40, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/c2fe9408_b055ade8 PS40, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/316df042_6cae04f7 PS40, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/b7fa7228_6b59b3c6 PS40, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/8b465862_49a03a62 PS40, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/ce7972c7_ae01132e PS40, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/853f80af_8ac34e3a PS40, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/0b5353ec_3d16b6c6 PS40, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/09cd46ec_fc703dd5 PS40, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/af7d2dad_784cb386 PS40, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/5d19c9b2_38c6d89d PS40, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/ad30d469_12a327bb PS40, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/d57edfb7_a6278667 PS40, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119802): https://review.coreboot.org/c/coreboot/+/49767/comment/ecfbfbb3_f70a0030 PS40, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line