HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45772 )
Change subject: mb/51nb/x210/acpi: Convert to to ASL 2.0 syntax ......................................................................
mb/51nb/x210/acpi: Convert to to ASL 2.0 syntax
Generated build/dsdt.dsl before and after current patch are same.
Change-Id: Ia0354e535229e832cf0e65cb8744a1ee8d5e8a34 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/platform.asl 3 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/45772/1
diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index f9022a4..b81af1f 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -37,19 +37,19 @@ Method (_BIF, 0, Serialized) { /* Design Capacity */ - Store (DGCP * 10000 / DGVO, Index (PBIF, 1)) + PBIF [One] = (DGCP * 10000) / DGVO
/* Last Full Charge Capacity */ - Store (FLCP * 10000 / DGVO, Index (PBIF, 2)) + PBIF [2] = (FLCP * 10000) / DGVO
/* Design Voltage */ - Store (DGVO, Index (PBIF, 4)) + PBIF [4] = DGVO
/* Design Capacity of Warning */ - Store (BDW * 10000 / DGVO, Index (PBIF, 5)) + PBIF [5] = (BDW * 10000) / DGVO
/* Design Capacity of Low */ - Store (BDL, Index (PBIF, 6)) + PBIF [6] = BDL
Return (PBIF) } @@ -70,22 +70,22 @@ * bit 1 = charging * bit 2 = critical level */ - Store (BSTS, Index (PBST, 0)) + PBST [0] = BSTS
/* * 1: BATTERY PRESENT RATE */ - Store (BPR, Index (PBST, 1)) + PBST [1] = BPR
/* * 2: BATTERY REMAINING CAPACITY */ - Store (BRC * 10000 / DGVO, Index (PBST, 2)) + PBST [2] = (BRC * 10000) / DGVO
/* * 3: BATTERY PRESENT VOLTAGE */ - Store (BPV, Index (PBST, 3)) + PBST [3] = BPV
Return (PBST) } diff --git a/src/mainboard/51nb/x210/acpi/ec.asl b/src/mainboard/51nb/x210/acpi/ec.asl index 78e156c..fc1aafc 100644 --- a/src/mainboard/51nb/x210/acpi/ec.asl +++ b/src/mainboard/51nb/x210/acpi/ec.asl @@ -45,10 +45,10 @@ Method (_REG, 2, NotSerialized) { /* Initialize AC power state */ - Store (ACIN, \PWRS) + PWRS = ACIN
/* Initialize LID switch state */ - Store (LIDC, \LIDS) + LIDS = LIDC }
/* KEY_BRIGHTNESSUP */ @@ -79,7 +79,7 @@ /* Lid event */ Method (_Q0E) { - Store (LIDC, \LIDS) + LIDS = LIDC Notify (LID0, 0x80) }
diff --git a/src/mainboard/51nb/x210/acpi/platform.asl b/src/mainboard/51nb/x210/acpi/platform.asl index 6cf3f32..3415767 100644 --- a/src/mainboard/51nb/x210/acpi/platform.asl +++ b/src/mainboard/51nb/x210/acpi/platform.asl @@ -14,7 +14,7 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 }
/* @@ -30,7 +30,7 @@
Method (_WAK, 1) { - Store(_SB.PCI0.LPCB.EC.LIDC, \LIDS) - Store(_SB.PCI0.LPCB.EC.ACIN, \PWRS) + LIDS = _SB.PCI0.LPCB.EC.LIDC + PWRS = _SB.PCI0.LPCB.EC.ACIN Return (Package (){ 0, 0 }) }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45772
to look at the new patch set (#2).
Change subject: mb/51nb/x210/acpi: Convert to to ASL 2.0 syntax ......................................................................
mb/51nb/x210/acpi: Convert to to ASL 2.0 syntax
Generated build/dsdt.dsl before and after current patch are same.
Change-Id: Ia0354e535229e832cf0e65cb8744a1ee8d5e8a34 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/acpi/battery.asl M src/mainboard/51nb/x210/acpi/ec.asl M src/mainboard/51nb/x210/acpi/platform.asl 3 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/45772/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45772 )
Change subject: mb/51nb/x210/acpi: Convert to to ASL 2.0 syntax ......................................................................
Abandoned
Merge Conflict
-
HAOUAS Elyes (Code Review)