Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Krishna P Bhat D, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86169?usp=email )
Change subject: soc/intel/common/block/cse: Add API to match current PM event
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/86169/comment/2ca21721_b0ada763?usp... :
PS3, Line 301: #define ME_HFSTS2_CUR_PM_EVENT_SHIFT 24
can we get a list from intel to understand what all pmevent values as per FWSTS2 register (Current P […]
There are 16 events listed in the doc. For now, we are hitting only this event that is equivalent to S5. I can update the API as `bool cse_match_host_cold_reset(void)` to check for an equivalent of S5 reset and include `Power cycle reset through CMOFF` event for now. We can internally update the API to check for other events as we learn more from Intel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9a49382ee2c1a8f59da6233e510cf2e38ac32ad
Gerrit-Change-Number: 86169
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 17:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com