Attention is currently required from: Paul Menzel.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84170?usp=email )
Change subject: commonlib/coreboot_tables.h: Increase GPIO_MAX_NAME_LENGTH to 17 for backlight enable
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84170/comment/6cffaec0_bed96bc0?usp... :
PS1, Line 7: Fix Wunterminated-string-initialization error
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/84170/comment/acec7bc5_8e712cbe?usp... :
PS1, Line 9: This to fix:
What GCC version do you use?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fca7f067dab07bda5a31c9b5796272bea9763e1
Gerrit-Change-Number: 84170
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 01 Sep 2024 05:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org