Change in coreboot[master]: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38801 )
Change subject: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING ......................................................................
Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING
Make sure MINIMAL_PCI_SCANNING has right dependency over PCI kconfig symbol.
Change-Id: I30b18345976e5d21ccedf8906985ff71e7d2815c Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38801/1
diff --git a/src/Kconfig b/src/Kconfig index 4253ec7..f75f942 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -369,9 +369,9 @@
config MINIMAL_PCI_SCANNING bool "Enable minimal PCI scanning" - depends on CONFIGURABLE_RAMSTAGE + depends on CONFIGURABLE_RAMSTAGE && PCI help - If this option is enabled, coreboot will scan only devices + If this option is enabled, coreboot will scan only PCI devices marked as mandatory in devicetree.cb endmenu
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38801 )
Change subject: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38801 )
Change subject: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38801 )
Change subject: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING ......................................................................
Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING
Make sure MINIMAL_PCI_SCANNING has right dependency over PCI kconfig symbol.
Change-Id: I30b18345976e5d21ccedf8906985ff71e7d2815c Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38801 Reviewed-by: Jeremy Soller jeremy@system76.com Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Jeremy Soller: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 4253ec7..f75f942 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -369,9 +369,9 @@
config MINIMAL_PCI_SCANNING bool "Enable minimal PCI scanning" - depends on CONFIGURABLE_RAMSTAGE + depends on CONFIGURABLE_RAMSTAGE && PCI help - If this option is enabled, coreboot will scan only devices + If this option is enabled, coreboot will scan only PCI devices marked as mandatory in devicetree.cb endmenu
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38801 )
Change subject: Kconfig: Add CONFIG_PCI dependency for CONFIG_MINIMAL_PCI_SCANNING ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/535 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/534 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/533
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Jeremy Soller (Code Review)
-
Martin Roth (Code Review)
-
Subrata Banik (Code Review)