Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
inteltool: add Lewisburg C62x chipset family PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, Document Number: 336067-007US, May 2019 https://www3.intel.com/content/dam/www/public/us/en/documents/ datasheets/c620-series-chipset-datasheet.pdf
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/1
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 76b1abe..15ad815 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -260,6 +260,13 @@ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM175, "HM175" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QM175, "QM175" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CM238, "CM238" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C621, "Lewisburg C621" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C622, "Lewisburg C622" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C624, "Lewisburg C624" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C625, "Lewisburg C625" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C626, "Lewisburg C626" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C627, "Lewisburg C627" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_C628, "Lewisburg C628" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H310, "H310" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H370, "H370" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z390, "Z390" }, diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 483c930..a0108ee 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -170,6 +170,14 @@ #define PCI_DEVICE_ID_INTEL_QM175 0xa153 #define PCI_DEVICE_ID_INTEL_CM238 0xa154
+#define PCI_DEVICE_ID_INTEL_LEWISBURG_C621 0xa1c1 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C622 0xa1c2 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C624 0xa1c3 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C625 0xa1c4 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C626 0xa1c5 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C627 0xa1c6 +#define PCI_DEVICE_ID_INTEL_LEWISBURG_C628 0xa1c7 + #define PCI_DEVICE_ID_INTEL_H310 0xa303 #define PCI_DEVICE_ID_INTEL_H370 0xa304 #define PCI_DEVICE_ID_INTEL_Z390 0xa305
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG@13 PS1, Line 13: datasheets/c620-series-chipset-datasheet.pdf Remove the link and just leave the document number as reference.
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 173: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C621 0xa1c1 Remove "LEWISBURG" to be consistent with the rest
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 179: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C628 0xa1c7 C629 is missing.
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 180: Please also add the Super SKU device IDs.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Christian Walter, Stefan Reinauer, Felix Singer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34941
to look at the new patch set (#2).
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
inteltool: add Lewisburg C62x chipset family PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, Document Number: 336067-007US, May 2019
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/2
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 173: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C621 0xa1c1
Remove "LEWISBURG" to be consistent with the rest
Done
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 179: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C628 0xa1c7
C629 is missing.
Done
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Christian Walter, Stefan Reinauer, Felix Singer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34941
to look at the new patch set (#3).
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
inteltool: add Lewisburg C62x chipset family PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, May 2019. Document Number: 336067-007US
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/3
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 180:
Please also add the Super SKU device IDs.
Do you mean the following identifiers:
A242 - Intel® C624 Series Chipset Supersku A243 - Intel® C627 Series Chipset Supersku A244 - Intel® C621 Series Chipset Supersku A245 - Intel® C627 Series Chipset Supersku A246 - Intel® C628 Series Chipset Supersku
?
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 180:
Do you mean the following identifiers: […]
Yes
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Christian Walter, Stefan Reinauer, Felix Singer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34941
to look at the new patch set (#4).
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
inteltool: add Lewisburg C62x chipset family PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, May 2019. Document Number: 336067-007US
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/4
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 180:
Yes
Done
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG@13 PS1, Line 13: datasheets/c620-series-chipset-datasheet.pdf
Remove the link and just leave the document number as reference.
Done
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h@... PS4, Line 173: #define PCI_DEVICE_ID_INTEL_C621 0xa1c1 Add "PROD" here to make the difference clear.
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h@... PS4, Line 182: #define PCI_DEVICE_ID_INTEL_C624_SUPER_SKU 0xa242 Remove "SKU", since this ID is the SKU. No need for extra mentioning it.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Christian Walter, Stefan Reinauer, Felix Singer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34941
to look at the new patch set (#5).
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
inteltool: add Lewisburg C62x chipset family PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, May 2019. Document Number: 336067-007US
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/5
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h@... PS4, Line 173: #define PCI_DEVICE_ID_INTEL_C621 0xa1c1
Add "PROD" here to make the difference clear.
Done
https://review.coreboot.org/c/coreboot/+/34941/4/util/inteltool/inteltool.h@... PS4, Line 182: #define PCI_DEVICE_ID_INTEL_C624_SUPER_SKU 0xa242
Remove "SKU", since this ID is the SKU. No need for extra mentioning it.
Done
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 6: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c... PS11, Line 263: _PROD I'd drop the _PROD here and in the following lines
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Christian Walter, Stefan Reinauer, Felix Singer, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34941
to look at the new patch set (#12).
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
inteltool: add Lewisburg family C62x chipset PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, May 2019. Document Number: 336067-007US
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34941/12
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c... PS11, Line 263: _PROD
I'd drop the _PROD here and in the following lines
I think it is better to leave it there, since for one chipset multiple SKUs can be available. So it makes the difference clear.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
Patch Set 13:
(1 comment)
will check the IDs against the datasheet later
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c... PS11, Line 263: _PROD
I think it is better to leave it there, since for one chipset multiple SKUs can be available. […]
IMHO the _PROD is just noise, since it is the normal case for those PCHs. To my knowledge the superset SKUs aren't even publicly available
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
Patch Set 13: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c... PS11, Line 263: _PROD
IMHO the _PROD is just noise, since it is the normal case for those PCHs. […]
Done
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs ......................................................................
inteltool: add Lewisburg family C62x chipset PCI IDs
These changes are in accordance with the documentation: [*] page 39, Intel(R) C620 Series Chipset Platform Controller Hub (PCH) Datasheet, May 2019. Document Number: 336067-007US
Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34941 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h 2 files changed, 27 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 76b1abe..cea3e0b 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -260,6 +260,19 @@ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM175, "HM175" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QM175, "QM175" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CM238, "CM238" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C621, "C621" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C622, "C622" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C624, "C624" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C625, "C625" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C626, "C626" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C627, "C627" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C628, "C628" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C629, "C629" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C624_SUPER, "C624 Super SKU" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C627_SUPER_1, "C627 Super SKU" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C621_SUPER, "C621 Super SKU" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C627_SUPER_2, "C627 Super SKU" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C628_SUPER, "C628 Super SKU" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H310, "H310" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H370, "H370" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z390, "Z390" }, diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 483c930..23b6d1d 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -170,6 +170,20 @@ #define PCI_DEVICE_ID_INTEL_QM175 0xa153 #define PCI_DEVICE_ID_INTEL_CM238 0xa154
+#define PCI_DEVICE_ID_INTEL_C621 0xa1c1 +#define PCI_DEVICE_ID_INTEL_C622 0xa1c2 +#define PCI_DEVICE_ID_INTEL_C624 0xa1c3 +#define PCI_DEVICE_ID_INTEL_C625 0xa1c4 +#define PCI_DEVICE_ID_INTEL_C626 0xa1c5 +#define PCI_DEVICE_ID_INTEL_C627 0xa1c6 +#define PCI_DEVICE_ID_INTEL_C628 0xa1c7 +#define PCI_DEVICE_ID_INTEL_C629 0xa1ca +#define PCI_DEVICE_ID_INTEL_C624_SUPER 0xa242 +#define PCI_DEVICE_ID_INTEL_C627_SUPER_1 0xa243 +#define PCI_DEVICE_ID_INTEL_C621_SUPER 0xa244 +#define PCI_DEVICE_ID_INTEL_C627_SUPER_2 0xa245 +#define PCI_DEVICE_ID_INTEL_C628_SUPER 0xa246 + #define PCI_DEVICE_ID_INTEL_H310 0xa303 #define PCI_DEVICE_ID_INTEL_H370 0xa304 #define PCI_DEVICE_ID_INTEL_Z390 0xa305
-
Felix Held (Code Review) -
Felix Singer (Code Review)
-
Maxim Polyakov (Code Review)
-
Nico Huber (Code Review)