Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 )
Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69639/comment/d58f7ef6_38ae6388
PS7, Line 7: mb/google/brya/acpi: Fix which param MAGA lies and add TPPA
Please split it into two commits.
I've updated to the comment to reflect more accurately what we're doing (general updates of the parameters). Let me know if you feel still strongly worthwhile to split.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f
Gerrit-Change-Number: 69639
Gerrit-PatchSet: 9
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment