Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52668 )
Change subject: soc/mediatek/mt8195: add pmif/spmi/pmic driver ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52668/comment/b52a0da0_ad982748 PS3, Line 9: MT8195
The IO pins, clock setting and PMIC setting related to SoC are difference from MT8192. […]
Ack
File src/soc/mediatek/mt8195/mt6315.c:
https://review.coreboot.org/c/coreboot/+/52668/comment/974788ef_5bde3a26 PS3, Line 6: /* disable magic key protection */
The setting is the PMIC internal setting. […]
Ack
File src/soc/mediatek/mt8195/pmif_clk.c:
PS3:
The clock register and bit definition are different to mt8192 even though it looks very similar to ` […]
Maybe at least we can extract pmif_ulposc_cali() to a common file, since the binary search should be independent of platforms, right?
File src/soc/mediatek/mt8195/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/52668/comment/2cff5b96_de6fc02a PS5, Line 114: printk(BIOS_ERR, "[%s] calibration fail: cur_val=%d, TOL_RATE=%d, target_val=%dM\n", Line too long
-
Yu-Ping Wu (Code Review)