Attention is currently required from: Maciej Pijanowski, Christian Walter, Krystian Hebel, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749 )
Change subject: util/cbmem: add parsing of TPM logs per standard
......................................................................
Patch Set 8:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/68749/comment/b0fcea9b_ddddd3ca
PS8, Line 298: const struct tpm_log_ref *range = cbmem_find(CBMEM_ID_TPM_LOG_REF);
I don't get it why do we need to define yet another CBMEM ID.
We can use the following function to get the start and size of the event log:
cbmem_entry_find(CBMEM_ID_TCPA_TCG_LOG) or cbmem_entry_find(CBMEM_ID_TPM2_TCG_LOG) then
cbmem_entry_start
cbmem_entry_size
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c
Gerrit-Change-Number: 68749
Gerrit-PatchSet: 8
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 10:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment