Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35435 )
Change subject: nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place ......................................................................
nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place
Change-Id: I872959c4a38e28c29220b81c9fe029e7fc553ccf Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/x201/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/northbridge/intel/nehalem/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/35435/1
diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 69e2038..0f8c4d4 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -31,10 +31,6 @@ string default "ThinkPad X201"
-config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index 6315591..932d6b8 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -30,10 +30,6 @@ string default "Packard Bell"
-config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index 9c74ef6..f500d63 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -52,4 +52,8 @@ hex default 0x10000
+config MMCONF_BASE_ADDRESS + hex + default 0xe0000000 + endif
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35435 )
Change subject: nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35435 )
Change subject: nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35435 )
Change subject: nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place ......................................................................
nb/nehalem: Move MMCONF_BASE_ADDRESS to a common place
Change-Id: I872959c4a38e28c29220b81c9fe029e7fc553ccf Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35435 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Alexander Couzens lynxis@fe80.eu Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x201/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/northbridge/intel/nehalem/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Alexander Couzens: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 69e2038..0f8c4d4 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -31,10 +31,6 @@ string default "ThinkPad X201"
-config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index 6315591..932d6b8 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -30,10 +30,6 @@ string default "Packard Bell"
-config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/northbridge/intel/nehalem/Kconfig b/src/northbridge/intel/nehalem/Kconfig index 9c74ef6..f500d63 100644 --- a/src/northbridge/intel/nehalem/Kconfig +++ b/src/northbridge/intel/nehalem/Kconfig @@ -52,4 +52,8 @@ hex default 0x10000
+config MMCONF_BASE_ADDRESS + hex + default 0xe0000000 + endif
-
Alexander Couzens (Code Review) -
Angel Pons (Code Review)
-
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)