Attention is currently required from: Jayvik Desai, Pranava Y N.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email )
Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85920/comment/45a2fe60_49151459?usp... : PS3, Line 7: select Select ?
https://review.coreboot.org/c/coreboot/+/85920/comment/c0f7f190_fe7bdaad?usp... : PS3, Line 9: This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image. looks to me a wrap up test ? should limit the commit msg < 72 char per line