Attention is currently required from: Subrata Banik, Rizwan Qureshi, Sridhar Siricilla, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62715 )
Change subject: soc/intel/common: Add support to control CSE firmware update
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/62715/comment/bb888f27_e71e6cfb
PS3, Line 34: fmap_locate_area_as_rdev_rw
Does fmap_locate_area_as_rdev work too? I'm not sure if this will attempt to use memory mapped medium, but it's worth the try as you don't seem to want to write to that region?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f234b142191eb83137d5d83f21e890e1cb828ba
Gerrit-Change-Number: 62715
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 28 Mar 2022 14:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment