Attention is currently required from: Angel Pons, Maximilian Brune.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 7:
(5 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163729): https://review.coreboot.org/c/coreboot/+/68137/comment/1db8107e_3a389044 PS7, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163729): https://review.coreboot.org/c/coreboot/+/68137/comment/eebc6b5c_325e7210 PS7, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163729): https://review.coreboot.org/c/coreboot/+/68137/comment/d7c69ffb_e013ea7d PS7, Line 14: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163729): https://review.coreboot.org/c/coreboot/+/68137/comment/6bde51bf_50f18f1b PS7, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163729): https://review.coreboot.org/c/coreboot/+/68137/comment/c33a53a4_b6aff9e6 PS7, Line 34: switch (vpd) { switch and case should be at the same indent