[M] Change in coreboot[main]: soc/amd/common/block/graphics: Use vbt_get()

[Felix Held (Code Review)]

Attention is currently required from: Andrey Petrov, Fred Reitberger, Intel coreboot Reviewers, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Ronak Kanabar.

Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86299?usp=email )

Change subject: soc/amd/common/block/graphics: Use vbt_get()
......................................................................

Patch Set 3: Code-Review+1

(2 comments)

File src/soc/amd/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/86299/comment/9ad37442_e032bd1b?usp... :
PS3, Line 149: /*
             :  * On AMD platforms the VBT is called ATOMBIOS and is always part of the
             :  * VGA Option ROM. As part of the FSP GOP init the ATOMBIOS tables are
             :  * updated in place. Thus the VBIOS must be loaded into RAM before FSP GOP
             :  * runs. The address of the VBIOS must be passed to FSP-S using UPDs, but
             :  * loading of the VBIOS can be delayed until before FSP AFTER_PCI_ENUM
             :  * notify is called. FSP expects a pointer to the PCI option rom instead
             :  * a pointer to the ATOMBIOS table directly.
             :  */
ah, this comment gets moved to the header file, so it's not just deleted

https://review.coreboot.org/c/coreboot/+/86299/comment/931f09b1_a53ba55b?usp... :
PS3, Line 151: 	if (!CONFIG(RUN_FSP_GOP))
> It's aligned to `src/soc/intel/common/vbt.c`.

hmm, consistency vs code being slightly easier to read. in this case, i'd probably rather go with the code being a bit easier to read, but i don't have a too strong opinion here