Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39339 )
Change subject: mb/google/volteer: add acpi info for mipi camera ......................................................................
mb/google/volteer: add acpi info for mipi camera
BUG=none TEST=none
Change-Id: I4a34205a128c66821454fd6081a72ae8c0c12829 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/acpi/mipi_camera.asl M src/mainboard/google/volteer/dsdt.asl 2 files changed, 533 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39339/1
diff --git a/src/mainboard/google/volteer/acpi/mipi_camera.asl b/src/mainboard/google/volteer/acpi/mipi_camera.asl new file mode 100644 index 0000000..e1ecc3a --- /dev/null +++ b/src/mainboard/google/volteer/acpi/mipi_camera.asl @@ -0,0 +1,530 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Scope (_SB.PCI0) +{ + Device (IPU0) + { + Name (_ADR, 0x00050000) + Name (_DDN, "Camera and Imaging Subsystem") + } +} + +Scope (_SB.PCI0.IPU0) +{ + Name (_DSD, Package (0x02) + { + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x02) + { + Package (0x02) + { + "port0", + "PRT0" + }, + + Package (0x02) + { + "port1", + "PRT1" + } + } + }) + + Name (PRT0, Package (0x04) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "port", + 5 + } + }, + + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "endpoint0", + "EP00" + } + } + }) + + Name (PRT1, Package (0x04) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "port", + 1 + } + }, + + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "endpoint0", + "EP10" + } + } + }) +} + +Scope (_SB.PCI0.IPU0) +{ + Name (EP00, Package (0x02) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x04) + { + Package (0x02) + { + "endpoint", + Zero + }, + + Package (0x02) + { + "clock-lanes", + Zero + }, + + Package (0x02) + { + "data-lanes", + Package (0x04) + { + One, + 0x02, + 0x03, + 0x04 + } + }, + + Package (0x02) + { + "remote-endpoint", + Package (0x03) + { + ^I2C3.CAM0, + Zero, + Zero + } + } + } + }) + Name (EP10, Package (0x02) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x04) + { + Package (0x02) + { + "endpoint", + Zero + }, + + Package (0x02) + { + "clock-lanes", + Zero + }, + + Package (0x02) + { + "data-lanes", + Package (0x04) + { + One, + 0x02 + } + }, + + Package (0x02) + { + "remote-endpoint", + Package (0x03) + { + ^I2C2.CAM1, + Zero, + Zero + } + } + } + }) +} + +Scope (_SB.PCI0.I2C3) +{ + PowerResource (RCPR, 0x00, 0x0000) + { + Name (STA, Zero) + Method (_ON, 0, Serialized) + { + If ((STA == Zero)) + { + /* Enable CLK3:19.2MHz */ + MCCT(3,1,1) + /* Pull PWREN(GPIO H20) high */ + STXS(GPP_H20) + Sleep(5) + /* Pull RST(GPIO D4) low */ + CTXS(GPP_D4) + Sleep(5) + /* Pull RST high */ + STXS(GPP_D4) + Sleep(5) + Store(1,STA) + } + } + + Method (_OFF, 0, Serialized) + { + If ((STA == One)) + { + /* Pull RST low */ + CTXS(GPP_D4) + /* Pull PWREN low */ + CTXS(GPP_H20) + /* Disable CLK3 */ + MCCT(3,0,1) + Store(0,STA) + } + } + + Method (_STA, 0, NotSerialized) + { + Return (STA) + } + } + + Device (CAM0) + { + Name (_HID, "OVTI8856") + Name (_UID, Zero) + Name (_DDN, "Ov 8856 Camera") + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\_SB.PCI0.I2C3", + 0x00, ResourceConsumer, , + ) + }) + + Name (_PR0, Package (0x01) + { + RCPR + }) + + Name (_PR3, Package (0x01) + { + RCPR + }) + + Name (_DSD, Package (0x04) + { + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "port0", + "PRT0" + } + }, + + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x02) + { + Package (0x02) + { + "clock-frequency", + 0x0124F800 + }, + Package (0x02) + { + "lens-focus", + Package (0x01) + { + VCM0 + } + } + } + }) + + Name (PRT0, Package (0x04) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "port", + Zero + } + }, + + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "endpoint0", + "EP00" + } + } + }) + + Name (EP00, Package (0x02) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x03) + { + Package (0x02) + { + "endpoint", + Zero + }, + + Package (0x02) + { + "link-frequencies", + Package (0x01) + { + 0x325AA000 + } + }, + Package (0x02) + { + "remote-endpoint", + Package (0x03) + { + IPU0, + Zero, + Zero + } + } + } + }) + } + + Device (VCM0) + { + Name (_HID, "PRP0001") + Name (_UID, 0x03) + Name (_DDN, "DW9714 VCM") + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\_SB.PCI0.I2C3", + 0x00, ResourceConsumer, , + ) + }) + Name (_DEP, Package (0x01) + { + CAM0 + }) + Name (_PR0, Package (0x01) + { + RCPR + }) + Name (_PR3, Package (0x01) + { + RCPR + }) + Name (_DSD, Package (0x02) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "compatible", + "dongwoon,dw9714" + } + } + }) + } +} + +Scope (_SB.PCI0.I2C2) +{ + PowerResource (FCPR, 0x00, 0x0000) + { + Name (STA, Zero) + Method (_ON, 0, Serialized) + { + If ((STA == Zero)) + { + /* Enable CLK2 : 19.2MHz */ + MCCT(2,1,1) + /* Pull PWREN(GPIO H20) high */ + STXS(GPP_H20) + Sleep(5) + /* Pull RST(GPIO D4) low */ + CTXS(GPP_D4) + Sleep(5) + /* Pull RST high */ + STXS(GPP_D4) + Sleep(5) + Store(1,STA) + } + } + + Method (_OFF, 0, Serialized) + { + If ((STA == One)) + { + /* Pull RST low */ + CTXS(GPP_D4) + /* Pull PWREN low */ + CTXS(GPP_H20) + /* Disable CLK2 */ + MCCT(2,0,1) + Store(0,STA) + } + } + + Method (_STA, 0, NotSerialized) + { + Return (STA) + } + } + + Device (CAM1) + { + Name (_HID, "OVTI2740") + Name (_UID, Zero) + Name (_DDN, "Ov 2740 Camera") + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\_SB.PCI0.I2C0", + 0x00, ResourceConsumer, , + ) + }) + + Name (_PR0, Package (0x01) + { + FCPR + }) + + Name (_PR3, Package (0x01) + { + FCPR + }) + + Name (_DSD, Package (0x04) + { + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "port0", + "PRT0" + } + }, + + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "clock-frequency", + 0x0124F800 + } + } + }) + + Name (PRT0, Package (0x04) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x01) + { + Package (0x02) + { + "port", + Zero + } + }, + + ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), + Package (0x01) + { + Package (0x02) + { + "endpoint0", + "EP00" + } + } + }) + + Name (EP00, Package (0x02) + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package (0x03) + { + Package (0x02) + { + "endpoint", + Zero + }, + + Package (0x02) + { + "link-frequencies", + Package (0x01) + { + 0x325AA000 + } + }, + Package (0x02) + { + "remote-endpoint", + Package (0x03) + { + IPU0, + One, + Zero + } + } + } + }) + } +} diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index f62780b..a51e5ee 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -48,4 +48,7 @@ }
#include <southbridge/intel/common/acpi/sleepstates.asl> + + /* MIPI camera */ + #include "acpi/mipi_camera.asl" }
Hello build bot (Jenkins), Furquan Shaikh, caveh jalali, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39339
to look at the new patch set (#2).
Change subject: mb/google/volteer: add acpi info for mipi camera ......................................................................
mb/google/volteer: add acpi info for mipi camera
BUG=none TEST=none
Change-Id: I4a34205a128c66821454fd6081a72ae8c0c12829 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/acpi/mipi_camera.asl M src/mainboard/google/volteer/dsdt.asl 2 files changed, 533 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39339/2
Hello build bot (Jenkins), Furquan Shaikh, caveh jalali, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39339
to look at the new patch set (#3).
Change subject: mb/google/volteer: add acpi info for mipi camera ......................................................................
mb/google/volteer: add acpi info for mipi camera
BUG=none TEST=none
Change-Id: I4a34205a128c66821454fd6081a72ae8c0c12829 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/acpi/mipi_camera.asl M src/mainboard/google/volteer/dsdt.asl 2 files changed, 533 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39339/3
Hello build bot (Jenkins), Furquan Shaikh, caveh jalali, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39339
to look at the new patch set (#4).
Change subject: mb/google/volteer: add acpi info for mipi camera ......................................................................
mb/google/volteer: add acpi info for mipi camera
BUG=none TEST=none
Change-Id: I4a34205a128c66821454fd6081a72ae8c0c12829 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/acpi/mipi_camera.asl M src/mainboard/google/volteer/dsdt.asl 2 files changed, 533 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39339/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39339 )
Change subject: mb/google/volteer: add acpi info for mipi camera ......................................................................
Patch Set 5: Code-Review-1
Let's hold off submitting this one. I want this to be moved to SSDT generation. See my comment on b/146512346.
Hello build bot (Jenkins), Furquan Shaikh, caveh jalali, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39339
to look at the new patch set (#6).
Change subject: mb/google/volteer: Add camera ACPI configuration ......................................................................
mb/google/volteer: Add camera ACPI configuration
MIPI camera ACPI configuration for volteer user facing camera is added.
BUG=b:146512346 BRANCH=none TEST=Boot to OS and test camera using the default camera app
Change-Id: I4a34205a128c66821454fd6081a72ae8c0c12829 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/acpi/mipi_camera.asl M src/mainboard/google/volteer/dsdt.asl 2 files changed, 533 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39339/6
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39339 )
Change subject: mb/google/volteer: Add camera ACPI configuration ......................................................................
Patch Set 6:
Patch Set 5: Code-Review-1
Let's hold off submitting this one. I want this to be moved to SSDT generation. See my comment on b/146512346.
OK, will move it out from the dependency stack.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39339 )
Change subject: mb/google/volteer: Add camera ACPI configuration ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39339/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/39339/6/src/mainboard/google/voltee... PS6, Line 16: Scope (_SB.PCI0) : { : Device (IPU0) : { : Name (_ADR, 0x00050000) : Name (_DDN, "Camera and Imaging Subsystem") : } : } : This is moved in soc folder. https://review.coreboot.org/c/coreboot/+/38469
Nick Vaccaro has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39339 )
Change subject: mb/google/volteer: Add camera ACPI configuration ......................................................................
Abandoned
-
Furquan Shaikh (Code Review) -
Nick Vaccaro (Code Review)
-
Wonkyu Kim (Code Review)