Change in coreboot[master]: mb/google/poppy: Add SPD mapping for Shyvana, Shyvana-M and Leona sup...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

27 Aug 2020 27 Aug '20

10:25 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: Add SPD mapping for Shyvana, Shyvana-M and Leona support ......................................................................

mb/google/poppy: Add SPD mapping for Shyvana, Shyvana-M and Leona support

Add SAMSUNG SPD file, and add "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" mapping.

BUG=none BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 --- A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex M src/mainboard/google/poppy/variants/rammus/Makefile.inc 2 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/1

diff --git a/src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex b/src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex new file mode 100644 index 0000000..168f15e --- /dev/null +++ b/src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex @@ -0,0 +1,16 @@ +91 20 F1 03 05 19 05 03 03 11 01 08 08 00 50 15 +78 78 90 50 90 11 50 E0 90 06 3C 3C 01 90 00 00 +00 00 C2 08 00 00 00 A8 00 88 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 80 CE 01 00 00 55 00 00 00 00 00 +4B 34 45 38 45 33 32 34 45 44 2D 45 47 43 47 20 +20 20 00 00 80 CE 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/poppy/variants/rammus/Makefile.inc b/src/mainboard/google/poppy/variants/rammus/Makefile.inc index 0d835cb..2baeb52 100644 --- a/src/mainboard/google/poppy/variants/rammus/Makefile.inc +++ b/src/mainboard/google/poppy/variants/rammus/Makefile.inc @@ -4,6 +4,8 @@ SPD_SOURCES += samsung_dimm_K4E6E304EC-EGCF # 0b0011 SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107 # 0b0100 SPD_SOURCES += hynix_dimm_H9CCNNNCLGALAR-NVD # 0b0101 +SPD_SOURCES += samsung_dimm_K4E8E324ED-EGCG # 0b0110 +SPD_SOURCES += samsung_dimm_K4E6E304ED-EGCG # 0b0111

bootblock-y += gpio.c

Attachments:

attachment.htm (text/html — 4.9 KB)

Show replies by date

Kane Chen (Code Review)

27 Aug 27 Aug

10:55 a.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana , Shyvana-M and Leona

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44854

to look at the new patch set (#2).

Change subject: mb/google/poppy: New SPD support for Shyvana , Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana , Shyvana-M and Leona

1. Add new spd file , "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in rammus memory table.

BUG=none BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/2

Kane Chen (Code Review)

12:19 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44854

to look at the new patch set (#3).

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

1. Add new spd file , "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in rammus memory table.

BUG=none BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/3

Kane Chen (Code Review)

12:19 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44854

to look at the new patch set (#4).

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

1. Add new SPD file, "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.

BUG=none BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/4

Kane Chen (Code Review)

12:58 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 10:58:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

1:35 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/4//COMMIT_MSG@13 PS4, Line 13: none You should have a bug for this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 11:35:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ken Lu (Code Review)

1:37 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has uploaded a new patch set (#5) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

1. Add new SPD file, "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.

BUG=166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: newpatchset

Ken Lu (Code Review)

1:38 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/4//COMMIT_MSG@13 PS4, Line 13: none

...

You should have a bug for this.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 11:38:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

2:02 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@11 PS5, Line 11: "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table. Add 3 space to align with 'Add"?

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@13 PS5, Line 13: 166576463 b:166576463

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 12:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ken Lu (Code Review)

2:11 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has uploaded a new patch set (#6) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

1. Add new SPD file, "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.

b:166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: newpatchset

Ken Lu (Code Review)

2:11 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@11 PS5, Line 11: "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.

...

Add 3 space to align with 'Add"?

Done

https://review.coreboot.org/c/coreboot/+/44854/5//COMMIT_MSG@13 PS5, Line 13: 166576463

...

b:166576463

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 12:11:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

2:16 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/6//COMMIT_MSG@13 PS6, Line 13: b:166576463 BUG=b:166576463

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 12:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ken Lu (Code Review)

2:18 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has uploaded a new patch set (#7) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

1. Add new SPD file, "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support of "samsung_dimm_K4E8E324ED-EGCG" and "samsung_dimm_K4E6E304ED-EGCG" in Rammus memory table.

BUG=b:166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: newpatchset

Ken Lu (Code Review)

2:20 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/6//COMMIT_MSG@13 PS6, Line 13: b:166576463

...

BUG=b:166576463

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Zhuohao Lee zhuohao@google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 12:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee zhuohao@google.com Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

2:25 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 27 Aug 2020 12:25:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:23 p.m.

New subject: Change in coreboot[master]: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona ......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG@7 PS7, Line 7: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona Please make it statement by using a verb (in imperative mood).

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG@7 PS7, Line 7: mb/google/poppy

...

mb/google/poppy/var/rammus: …

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Aug 2020 14:23:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

28 Aug 28 Aug

5:06 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Zhuohao Lee, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44854

to look at the new patch set (#8).

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

mb/google/poppy/var/rammus: Update SPD table for Rammus

1. Add new SPD file, "samsung_dimm_K4E8E324ED-EGCG.spd.hex". 2. Add SPD support in Rammus memory table, as follows: SPD_SOURCES += samsung_dimm_K4E8E324ED-EGCG # 0b0110 SPD_SOURCES += samsung_dimm_K4E6E304ED-EGCG # 0b0111

BUG=b:166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 8 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

5:07 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG@7 PS7, Line 7: mb/google/poppy: New SPD support for Shyvana, Shyvana-M and Leona

...

Please make it statement by using a verb (in imperative mood).

Done

https://review.coreboot.org/c/coreboot/+/44854/7//COMMIT_MSG@7 PS7, Line 7: mb/google/poppy

...

...
mb/google/poppy/var/rammus: …

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 8 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 28 Aug 2020 03:07:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

2 Sep 2 Sep

8:42 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 8 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 02 Sep 2020 06:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

8:43 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 8: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 8 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 02 Sep 2020 06:43:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Zhuohao Lee (Code Review)

8:45 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG@11 PS8, Line 11: SPD_SOURCES += samsung_dimm_K4E8E324ED-EGCG # 0b0110 : SPD_SOURCES += samsung_dimm_K4E6E304ED-EGCG # 0b0111 Please add space to align with 'Add ...'

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 8 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 02 Sep 2020 06:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

8:49 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Zhuohao Lee, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44854

to look at the new patch set (#9).

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

mb/google/poppy/var/rammus: Update SPD table for Rammus

BUG=b:166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44854/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 9 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Ken Lu (Code Review)

9:03 a.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG@11 PS8, Line 11: SPD_SOURCES += samsung_dimm_K4E8E324ED-EGCG # 0b0110 : SPD_SOURCES += samsung_dimm_K4E6E304ED-EGCG # 0b0111

...

Please add space to align with 'Add ... […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 9 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 02 Sep 2020 07:03:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee zhuohao@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:36 p.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 9 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 02 Sep 2020 10:36:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:36 p.m.

New subject: Change in coreboot[master]: mb/google/poppy/var/rammus: Update SPD table for Rammus

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44854 )

Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus ......................................................................

mb/google/poppy/var/rammus: Update SPD table for Rammus

BUG=b:166576463 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, and make sure system boots up.

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44854 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Zhuohao Lee zhuohao@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex M src/mainboard/google/poppy/variants/rammus/Makefile.inc 2 files changed, 18 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve Kane Chen: Looks good to me, but someone else must approve

bootblock-y += gpio.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/44854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196 Gerrit-Change-Number: 44854 Gerrit-PatchSet: 10 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1543

days inactive

1549

days old

coreboot-gerrit@coreboot.org

24 comments

5 participants

tags (0)

participants (5)

Kane Chen (Code Review)
Ken Lu (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Zhuohao Lee (Code Review)