Attention is currently required from: Martin L Roth, Patrick Rudolph, Jakub Czapiga, Matt DeVillier, Angel Pons, Arthur Heymans, Martin Roth, David Milosevic.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: drivers/efi: Add EFI variable store option support
......................................................................
Patch Set 23:
(1 comment)
File src/drivers/efi/Kconfig:
https://review.coreboot.org/c/coreboot/+/52564/comment/d105619d_c054c8fc
PS10, Line 1: DRIVERS_EFI_VARIABLE_STORE
Including multiple UDK could result in conflicts. […]
- Pi/UefiBaseType.h: Includes Base.h, which includes ProcessorBind.h. These aren't too likely to change: they're compiler pragmas, attributes, processor and UEFI-specific defines.
- Pi/UefiMultiPhase.h: Includes Guid/WinCertificate.h. Its contents aren't important here.
It's a bigger issue here if there's no UDK (maybe if another driver includes incorrect headers too). vendorcode/intel/Makefile.inc is a 'if BINDING, elseif BINDING, endif' statement, so we can only use one set.
So, how about some of each: Including these headers directly, and `select UDK_2017_BINDING if !(UEFI_2_4_BINDING || UDK_202005_BINDING || UDK_202111_BINDING)` - it's inefficient and will probably break, but it at least avoids recursive dependencies.
If EDK2 headers will be used more in the codebase, it would be better to pass bindings more specifically to compiler units.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 23
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Mon, 13 Mar 2023 16:44:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment