Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29318 )
Change subject: siemens/mc_apl2: Adjust GPIO settings for mc_apl2
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29318/2/src/mainboard/siemens/mc_apl1/varian...
File src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c:
https://review.coreboot.org/#/c/29318/2/src/mainboard/siemens/mc_apl1/varian...
PS2, Line 97: MASK
Please align the indention to match with the open bracket of the macro.
This is spread across the whole file whenever a line was split.
--
To view, visit
https://review.coreboot.org/29318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16387358d6c6fa15efd16f7ba7f6b89740477e9d
Gerrit-Change-Number: 29318
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Pöche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Nov 2018 08:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No