Change in coreboot[master]: mb/lenovo/t60: Add support for ThinkLight

[Stefan Ott (Code Review)]

Stefan Ott has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40678 )


Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled
through the OS.  This was initially done for the X201 in f63fbdb6:
mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

    echo on >/proc/acpi/ibm/light
    echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Unfortunately I do not own a T60 to test this.

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Signed-off-by: Stefan Ott <[e-mail]>
---
M src/mainboard/lenovo/t60/dsdt.asl
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/1

diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl
index 51ff336..cab3ddb 100644
--- a/src/mainboard/lenovo/t60/dsdt.asl
+++ b/src/mainboard/lenovo/t60/dsdt.asl
@@ -48,4 +48,6 @@
 
 	// Dock support code
 	#include "acpi/dock.asl"
+
+	#include <ec/lenovo/h8/acpi/thinklight.asl>
 }

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 1: Code-Review+1

Waiting for test...


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 23 Apr 2020 21:52:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 1:

I should be able to test this next week.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 24 Apr 2020 12:38:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Alexander Couzens (Code Review)]

Attention is currently required from: Stefan Ott.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Comment-Date: Sat, 27 Feb 2021 01:48:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Attention is currently required from: Stefan Ott, Alexander Couzens.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/91710b94_fe058d9f 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.


Patchset:

PS2: 
Hi Alexander, were you able to test this patch? If so, I'd suggest updating the commit message.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Comment-Date: Sat, 27 Feb 2021 10:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Alexander Couzens (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons.
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/5cb9967f_abc8db94 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.
> No I didn't tested it (yet). But my educated guess it, it's working just that way. I'll try to test it on x60.

[Cuno (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens.
Cuno has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/99a2dcd4_8ae05490 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> No I didn't tested it (yet). But my educated guess it, it's working just that way. […]
> I tested this and it works on both T60 and R60.

[Paul Menzel (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Patchset:

PS3: 
Awesome, thank you for testing.

PS: If you own a Lenovo T60, it’d be great if you uploaded the logs from an image built from the master branch (maybe after this change-set is merged) to the board status repository (cf. `util/board_status/board_status.sh`).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Comment-Date: Thu, 13 Jan 2022 07:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Attention is currently required from: Stefan Ott, Alexander Couzens, Cuno.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/ec934779_2d181c7b 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> I tested this and it works on both T60 and R60.

Thanks!

@Stefan, could you please remove this line?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-Comment-Date: Thu, 13 Jan 2022 12:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons <[e-mail]>
Comment-In-Reply-To: Alexander Couzens <[e-mail]>
Comment-In-Reply-To: Cuno
Gerrit-MessageType: comment

[Name of user not set (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens, Cuno.
Name of user not set #1004271 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/68859162_bfd58e20 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> > I tested this and it works on both T60 and R60. […]
> > Can confirm this still works on T60 on master pulled today.

[Stefan Ott (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens, Cuno.
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/40678

to look at the new patch set (#4).

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled
through the OS.  This was initially done for the X201 in f63fbdb6:
mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

    echo on >/proc/acpi/ibm/light
    echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Signed-off-by: Stefan Ott <[e-mail]>
---
M src/mainboard/lenovo/t60/dsdt.asl
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-MessageType: newpatchset

[Stefan Ott (Code Review)]

Attention is currently required from: Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno.
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/dde00bdc_0c7e7a0e 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> Can confirm this still works on T60 on master pulled today.
> Done

Patchset:

PS4: 
Thank you



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-Comment-Date: Sun, 10 Apr 2022 01:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <[e-mail]>
Comment-In-Reply-To: Name of user not set #1004271
Comment-In-Reply-To: Alexander Couzens <[e-mail]>
Comment-In-Reply-To: Cuno
Gerrit-MessageType: comment

[Felix Singer (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/48567630_1ec93377 
PS4, Line 21: Signed-off-by: Stefan Ott <[e-mail]>
Add a Tested-by line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-Comment-Date: Sun, 10 Apr 2022 01:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Stefan Ott (Code Review)]

Attention is currently required from: Felix Singer, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno.
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/25419f27_3059d35b 
PS4, Line 21: Signed-off-by: Stefan Ott <[e-mail]>
> Add a Tested-by line
> Should I add that or can the testers add that themselves?

[Felix Singer (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/470b4d88_17a68a7d 
PS4, Line 21: Signed-off-by: Stefan Ott <[e-mail]>
> Should I add that or can the testers add that themselves?
> Can be added by anyone.

[Paul Menzel (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

Patchset:

PS4: 
Side note, WinterSolstice8 [uploaded the logs (without this patch) to the board status repository]():

    lenovo/t60/4.16-536-g662353ac3e/2022-04-06T23_42_56Z

Note, coreboot and SeaBIOS both execute the ATI/AMD Video/VGA BIOS Option ROM. If SeaBIOS is used as payload, it’s recommended, that only SeaBIOS runs it, but of course that means you’d need to rebuild coreboot if you want to change the payload to one not able to execute Option ROMs.

[1]: https://review.coreboot.org/plugins/gitiles/board-status/+/1ef7bc3b831dac18f...



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-Comment-Date: Sun, 10 Apr 2022 04:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Attention is currently required from: Stefan Ott, Name of user not set #1004271, Alexander Couzens, Cuno.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-Comment-Date: Sun, 10 Apr 2022 07:31:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Stefan Ott (Code Review)]

Attention is currently required from: Stefan Ott, Martin Roth, Name of user not set #1004271, Alexander Couzens, Cuno.
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/40678

to look at the new patch set (#6).

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled
through the OS.  This was initially done for the X201 in f63fbdb6:
mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

    echo on >/proc/acpi/ibm/light
    echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Signed-off-by: Stefan Ott <[e-mail]>
---
M src/mainboard/lenovo/t60/dsdt.asl
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/6
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 6
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Martin Roth <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Attention: Alexander Couzens <[e-mail]>
Gerrit-Attention: Cuno
Gerrit-MessageType: newpatchset

[Stefan Ott (Code Review)]

Stefan Ott has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Abandoned
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-MessageType: abandon

[Stefan Ott (Code Review)]

Stefan Ott has restored this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Restored
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-MessageType: restore

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Cuno from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed cc Cuno.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Alexander Couzens from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed reviewer Alexander Couzens.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 7:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/655c64e1_d5f9f075 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> Done
> WinterSolstice8, would you mind adding a Tested-by line to the comment?

Patchset:

PS7: 
WinterSolstice8, would you mind adding a Tested-by line to the comment?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-Comment-Date: Fri, 06 May 2022 22:57:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Ott <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Comment-In-Reply-To: Name of user not set #1004271
Comment-In-Reply-To: Alexander Couzens <[e-mail]>
Comment-In-Reply-To: Cuno
Gerrit-MessageType: comment

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Angel Pons from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed reviewer Angel Pons.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Felix Singer from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed cc Felix Singer.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Maciej Matuszczyk from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed cc Maciej Matuszczyk.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Patrick Rudolph from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed reviewer Patrick Rudolph.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Stefan Ott (Code Review)]

Attention is currently required from: Name of user not set #1004271.
Stefan Ott has removed Paul Menzel from this change.  ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Removed reviewer Paul Menzel.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Cuno
Gerrit-CC: Maciej Matuszczyk <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Name of user not set #1004271
Gerrit-MessageType: deleteReviewer

[Angel Pons (Code Review)]

Attention is currently required from: Stefan Ott, Name of user not set #1004271.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 7: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-Attention: Stefan Ott <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Comment-Date: Sat, 07 May 2022 09:38:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Attention is currently required from: Stefan Ott, Name of user not set #1004271.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/f3796bbb_97dbb6f8 
PS4, Line 21: Signed-off-by: Stefan Ott <[e-mail]>
> Can be added by anyone.
> Yes, you can add it yourself

[Paul Menzel (Code Review)]

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 7:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/2bb80318_a7ff87bc 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> WinterSolstice8, would you mind adding a Tested-by line to the comment?
> I think it’s formally not needed, and you can just tag the comment as resolved.

[Stefan Ott (Code Review)]

Attention is currently required from: Paul Menzel, Angel Pons, Name of user not set #1004271.
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 7:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/48ced88c_4910c8b0 
PS2, Line 20: Unfortunately I do not own a T60 to test this.
> I think it’s formally not needed, and you can just tag the comment as resolved.
> Ack

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/09e028fb_eb2c091f 
PS4, Line 21: Signed-off-by: Stefan Ott <[e-mail]>
> Yes, you can add it yourself
> Ack

Patchset:

PS7: 
Okay, thanks



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Paul Menzel <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Name of user not set #1004271
Gerrit-Comment-Date: Sat, 07 May 2022 23:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Ott <[e-mail]>
Comment-In-Reply-To: Felix Singer <[e-mail]>
Comment-In-Reply-To: Paul Menzel <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Comment-In-Reply-To: Name of user not set #1004271
Comment-In-Reply-To: Alexander Couzens <[e-mail]>
Comment-In-Reply-To: Cuno
Gerrit-MessageType: comment

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled
through the OS.  This was initially done for the X201 in f63fbdb6:
mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

    echo on >/proc/acpi/ibm/light
    echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Signed-off-by: Stefan Ott <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40678
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: Angel Pons <[e-mail]>
Reviewed-by: Paul Menzel <[e-mail]>
---
M src/mainboard/lenovo/t60/dsdt.asl
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved



diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl
index 5847580..a2800a7 100644
--- a/src/mainboard/lenovo/t60/dsdt.asl
+++ b/src/mainboard/lenovo/t60/dsdt.asl
@@ -47,4 +47,6 @@
 
 	// Dock support code
 	#include "acpi/dock.asl"
+
+	#include <ec/lenovo/h8/acpi/thinklight.asl>
 }

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 8
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Werner Zeh <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight
......................................................................


Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 3 / 8 / 11
     
PASS: x86_32  "Hermes CFL" , build config PRODRIVE_HERMES_ 
     and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/103597
PASS: x86_32  "Hermes CFL" , build config PRODRIVE_HERMES 
     and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/103596
FAIL: x86_32  "ThinkPad T500" , build config LENOVO_T500 
     and payload SeaBIOS : https://lava.9esec.io/r/103595
PASS: x86_32  "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION 
     and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/103594
FAIL: x86_64  "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 
     and payload TianoCore : https://lava.9esec.io/r/103593
FAIL: x86_64  "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 
     and payload SeaBIOS : https://lava.9esec.io/r/103592
FAIL: x86_32  "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC 
     and payload TianoCore : https://lava.9esec.io/r/103591
FAIL: x86_32  "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC 
     and payload SeaBIOS : https://lava.9esec.io/r/103590
FAIL: x86_64  "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 
     and payload SeaBIOS : https://lava.9esec.io/r/103589
FAIL: x86_32  "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN 
     and payload SeaBIOS : https://lava.9esec.io/r/103588
FAIL: x86_32  "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX 
     and payload SeaBIOS : https://lava.9esec.io/r/103586

Please note: This test is under development and might not be accurate at all!


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9
Gerrit-Change-Number: 40678
Gerrit-PatchSet: 8
Gerrit-Owner: Stefan Ott <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Werner Zeh <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: 9elements QA <[e-mail]>
Gerrit-CC: Name of user not set #1004271
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 17 May 2022 11:32:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment