Change in coreboot[master]: mb/lenovo/t60: Add support for ThinkLight

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Stefan Ott (Code Review)

23 Apr 2020 23 Apr '20

11:28 p.m.

Stefan Ott has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Unfortunately I do not own a T60 to test this.

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/t60/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/1

diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index 51ff336..cab3ddb 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -48,4 +48,6 @@

// Dock support code #include "acpi/dock.asl" + + #include <ec/lenovo/h8/acpi/thinklight.asl> }

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by thread

Angel Pons (Code Review)

23 Apr 23 Apr

11:52 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 1: Code-Review+1

Waiting for test...

Paul Menzel (Code Review)

24 Apr 24 Apr

2:38 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 1:

I should be able to test this next week.

Alexander Couzens (Code Review)

27 Feb 27 Feb

2:48 a.m.

Attention is currently required from: Stefan Ott. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 2: Code-Review+2

Angel Pons (Code Review)

11:19 a.m.

Attention is currently required from: Stefan Ott, Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/91710b94_fe058d9f PS2, Line 20: Unfortunately I do not own a T60 to test this. If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.

Patchset:

PS2: Hi Alexander, were you able to test this patch? If so, I'd suggest updating the commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Comment-Date: Sat, 27 Feb 2021 10:19:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alexander Couzens (Code Review)

8 Mar 8 Mar

12:24 a.m.

Attention is currently required from: Stefan Ott, Angel Pons. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/5cb9967f_abc8db94 PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.

No I didn't tested it (yet). But my educated guess it, it's working just that way. I'll try to test it on x60.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sun, 07 Mar 2021 23:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Cuno (Code Review)

12 Jan 12 Jan

8:33 p.m.

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens. Cuno has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/99a2dcd4_8ae05490 PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

No I didn't tested it (yet). But my educated guess it, it's working just that way. […]

I tested this and it works on both T60 and R60.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Comment-Date: Wed, 12 Jan 2022 19:33:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Gerrit-MessageType: comment

Paul Menzel (Code Review)

13 Jan 13 Jan

8:11 a.m.

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

Patchset:

PS3: Awesome, thank you for testing.

PS: If you own a Lenovo T60, it’d be great if you uploaded the logs from an image built from the master branch (maybe after this change-set is merged) to the board status repository (cf. `util/board_status/board_status.sh`).

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Comment-Date: Thu, 13 Jan 2022 07:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:37 p.m.

Attention is currently required from: Stefan Ott, Alexander Couzens, Cuno. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/ec934779_2d181c7b PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

I tested this and it works on both T60 and R60.

Thanks!

@Stefan, could you please remove this line?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Thu, 13 Jan 2022 12:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Name of user not set (Code Review)

10 Apr 10 Apr

2:17 a.m.

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens, Cuno. Name of user not set #1004271 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/68859162_bfd58e20 PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

...
I tested this and it works on both T60 and R60. […]

Can confirm this still works on T60 on master pulled today.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 00:17:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Stefan Ott (Code Review)

3:24 a.m.

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens, Cuno. Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40678

to look at the new patch set (#4).

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/t60/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

3:26 a.m.

Attention is currently required from: Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno. Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/dde00bdc_0c7e7a0e PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

Can confirm this still works on T60 on master pulled today.

Done

Patchset:

PS4: Thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 01:26:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Name of user not set #1004271 Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Felix Singer (Code Review)

3:27 a.m.

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/48567630_1ec93377 PS4, Line 21: Signed-off-by: Stefan Ott stefan@ott.net Add a Tested-by line

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 01:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Ott (Code Review)

3:33 a.m.

Attention is currently required from: Felix Singer, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno. Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/25419f27_3059d35b PS4, Line 21: Signed-off-by: Stefan Ott stefan@ott.net

...

Add a Tested-by line

Should I add that or can the testers add that themselves?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 01:33:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Gerrit-MessageType: comment

Felix Singer (Code Review)

3:36 a.m.

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/470b4d88_17a68a7d PS4, Line 21: Signed-off-by: Stefan Ott stefan@ott.net

...

Should I add that or can the testers add that themselves?

Can be added by anyone.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 01:36:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Ott coreboot@desire.ch Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

6:54 a.m.

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271, Alexander Couzens, Cuno. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4: Code-Review+1

(1 comment)

Patchset:

PS4: Side note, WinterSolstice8 [uploaded the logs (without this patch) to the board status repository]():

lenovo/t60/4.16-536-g662353ac3e/2022-04-06T23_42_56Z

Note, coreboot and SeaBIOS both execute the ATI/AMD Video/VGA BIOS Option ROM. If SeaBIOS is used as payload, it’s recommended, that only SeaBIOS runs it, but of course that means you’d need to rebuild coreboot if you want to change the payload to one not able to execute Option ROMs.

[1]: https://review.coreboot.org/plugins/gitiles/board-status/+/1ef7bc3b831dac18f...

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 04:54:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

9:31 a.m.

Attention is currently required from: Stefan Ott, Name of user not set #1004271, Alexander Couzens, Cuno. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-Comment-Date: Sun, 10 Apr 2022 07:31:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Ott (Code Review)

6:37 p.m.

Attention is currently required from: Stefan Ott, Martin Roth, Name of user not set #1004271, Alexander Couzens, Cuno. Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40678

to look at the new patch set (#6).

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/t60/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Martin Roth martinroth@google.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Attention: Alexander Couzens lynxis@fe80.eu Gerrit-Attention: Cuno Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

7 May 7 May

12:53 a.m.

Stefan Ott has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Abandoned

Stefan Ott (Code Review)

12:53 a.m.

Stefan Ott has restored this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Restored

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 7:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/655c64e1_d5f9f075 PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

Done

WinterSolstice8, would you mind adding a Tested-by line to the comment?

Patchset:

PS7: WinterSolstice8, would you mind adding a Tested-by line to the comment?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Cuno Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-CC: Name of user not set #1004271 Gerrit-Attention: Name of user not set #1004271 Gerrit-Comment-Date: Fri, 06 May 2022 22:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Ott coreboot@desire.ch Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Name of user not set #1004271 Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed reviewer Patrick Rudolph.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed reviewer Paul Menzel.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Cuno from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed cc Cuno.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Alexander Couzens from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed reviewer Alexander Couzens.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Maciej Matuszczyk from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed cc Maciej Matuszczyk.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Felix Singer from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed cc Felix Singer.

Stefan Ott (Code Review)

12:57 a.m.

Attention is currently required from: Name of user not set #1004271. Stefan Ott has removed Angel Pons from this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Removed reviewer Angel Pons.

Angel Pons (Code Review)

11:38 a.m.

Attention is currently required from: Stefan Ott, Name of user not set #1004271. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 7: Code-Review+1

Angel Pons (Code Review)

11:39 a.m.

Attention is currently required from: Stefan Ott, Name of user not set #1004271. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 7: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/f3796bbb_97dbb6f8 PS4, Line 21: Signed-off-by: Stefan Ott stefan@ott.net

...

Can be added by anyone.

Yes, you can add it yourself

Paul Menzel (Code Review)

11:27 p.m.

Attention is currently required from: Stefan Ott, Angel Pons, Name of user not set #1004271. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 7:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/2bb80318_a7ff87bc PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

WinterSolstice8, would you mind adding a Tested-by line to the comment?

I think it’s formally not needed, and you can just tag the comment as resolved.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Name of user not set #1004271 Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Stefan Ott coreboot@desire.ch Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Comment-Date: Sat, 07 May 2022 21:27:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Ott coreboot@desire.ch Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Name of user not set #1004271 Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Stefan Ott (Code Review)

8 May 8 May

1 a.m.

Attention is currently required from: Paul Menzel, Angel Pons, Name of user not set #1004271. Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 7:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/48ced88c_4910c8b0 PS2, Line 20: Unfortunately I do not own a T60 to test this.

...

I think it’s formally not needed, and you can just tag the comment as resolved.

Ack

Commit Message:

https://review.coreboot.org/c/coreboot/+/40678/comment/09e028fb_eb2c091f PS4, Line 21: Signed-off-by: Stefan Ott stefan@ott.net

...

Yes, you can add it yourself

Ack

Patchset:

PS7: Okay, thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/40678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Name of user not set #1004271 Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Name of user not set #1004271 Gerrit-Comment-Date: Sat, 07 May 2022 23:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Ott coreboot@desire.ch Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Name of user not set #1004271 Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Comment-In-Reply-To: Cuno Gerrit-MessageType: comment

Werner Zeh (Code Review)

16 May 16 May

6:38 a.m.

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

mb/lenovo/t60: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad T60 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Signed-off-by: Stefan Ott stefan@ott.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/40678 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/mainboard/lenovo/t60/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index 5847580..a2800a7 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -47,4 +47,6 @@

// Dock support code #include "acpi/dock.asl" + + #include <ec/lenovo/h8/acpi/thinklight.asl> }

9elements QA (Code Review)

17 May 17 May

1:32 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )

Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................

Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 3 / 8 / 11

PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/103597 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/103596 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/103595 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/103594 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/103593 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/103592 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/103591 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/103590 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/103589 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/103588 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/103586

Please note: This test is under development and might not be accurate at all!

709

days inactive

1463

days old

coreboot-gerrit@coreboot.org

33 comments

9 participants

tags (0)

participants (9)

9elements QA (Code Review)
Alexander Couzens (Code Review)
Angel Pons (Code Review)
Cuno (Code Review)
Felix Singer (Code Review)
Name of user not set (Code Review)
Paul Menzel (Code Review)
Stefan Ott (Code Review)
Werner Zeh (Code Review)