Stefan Ott has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
mb/lenovo/t60: Add support for ThinkLight
With this patch, the ThinkLight on the ThinkPad T60 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.
After applying this patch, the light can be controlled like this:
echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light
Or through sysfs at /sys/class/leds/tpacpi::thinklight
Unfortunately I do not own a T60 to test this.
Change-Id: I47f878533d36857d002d2e2605cc8bc7e1d960c9 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/t60/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/40678/1
diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index 51ff336..cab3ddb 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -48,4 +48,6 @@
// Dock support code #include "acpi/dock.asl" + + #include <ec/lenovo/h8/acpi/thinklight.asl> }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
Patch Set 1: Code-Review+1
Waiting for test...
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
Patch Set 1:
I should be able to test this next week.
Attention is currently required from: Stefan Ott, Angel Pons. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40678/comment/5cb9967f_abc8db94 PS2, Line 20: Unfortunately I do not own a T60 to test this.
If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.
No I didn't tested it (yet). But my educated guess it, it's working just that way. I'll try to test it on x60.
Attention is currently required from: Stefan Ott, Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40678/comment/91710b94_fe058d9f PS2, Line 20: Unfortunately I do not own a T60 to test this. If this patch has now been tested, this should be dropped. I'd also add a Tested-by tag.
Patchset:
PS2: Hi Alexander, were you able to test this patch? If so, I'd suggest updating the commit message.
Attention is currently required from: Stefan Ott. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40678 )
Change subject: mb/lenovo/t60: Add support for ThinkLight ......................................................................
Patch Set 2: Code-Review+2
-
Alexander Couzens (Code Review) -
Angel Pons (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Ott (Code Review)