Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, hualin wei.
Subrata Banik has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86554?usp=email )
Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/gpio.c:
https://review.coreboot.org/c/coreboot/+/86554/comment/90425d8f_da5e67eb?usp... :
PS2, Line 456: DECLARE_WEAK_CROS_GPIOS
why ?
the definition of `cros_gpios` is exactly same between this file and newly introduced https://review.coreboot.org/c/coreboot/+/86554/2/src/mainboard/google/brya/v...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic92ff33a5fde50a1a400043b2daba0414eb9e255
Gerrit-Change-Number: 86554
Gerrit-PatchSet: 2
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 02:15:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No