Attention is currently required from: Ayan Agrawal, Daniel Maslowski, Daniel Maslowski, Philipp Hug, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77410?usp=email )
Change subject: qemu-riscv: Improve Documentation
......................................................................
Patch Set 3:
(2 comments)
File src/arch/riscv/romstage.S:
https://review.coreboot.org/c/coreboot/+/77410/comment/632b28be_a25f9588 :
PS3, Line 39:
Unrelated to the documentation. Normally I'd let something like this go by, but the other file is also unrelated to documentation, so we might as well remove this as well.
File src/mainboard/emulation/qemu-riscv/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/77410/comment/475b4365_3a603206 :
PS3, Line 35:
This removal is unrelated to the documentation - Move it to a cleanup patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7
Gerrit-Change-Number: 77410
Gerrit-PatchSet: 3
Gerrit-Owner: Ayan Agrawal
ayanagr03@gmail.com
Gerrit-Reviewer: Daniel Maslowski
cyrevolt@googlemail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Ayan Agrawal
ayanagr03@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Daniel Maslowski
info@orangecms.org
Gerrit-Attention: Daniel Maslowski
cyrevolt@googlemail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 31 Aug 2023 21:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment