Attention is currently required from: Felix Singer, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53925 )
Change subject: soc/intel/skylake: Set proper defaults in chipset devicetree
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
In theory we could remove the entries from the affected mainboard
devicetrees then. cf.
git grep '1f.[012]' -- $(dirname $(git grep -El 'SOC_INTEL_(SKY|KABY)LAKE>' src/mainboard/*/*/Kconfig))
There's only one `off` and one `hidden`. Both probably spurious.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b8cbe536da70fccc3d11e1eedf4a5e14bfc862
Gerrit-Change-Number: 53925
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 07 May 2021 20:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment