Attention is currently required from: Kane Chen, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................
Patch Set 22:
(4 comments)
File src/soc/intel/meteorlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/74769/comment/004789f4_29feff6b :
PS21, Line 61: /* Program BAR 0 and enable command register memory space decoding */
before programming the BAR the best practice says, try to disable the MMIO and IO space and then wri […]
Done
https://review.coreboot.org/c/coreboot/+/74769/comment/f19e6d26_3cec2d04 :
PS21, Line 75: BIOS_DEBUG
should be BIOS_ERROR?
Done
https://review.coreboot.org/c/coreboot/+/74769/comment/2e5b0dce_504c4da0 :
PS21, Line 80: BIOS_DEBUG
same?
Done
https://review.coreboot.org/c/coreboot/+/74769/comment/1f76a62e_8abd656d :
PS21, Line 85: BIOS_DEBUG
same?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5
Gerrit-Change-Number: 74769
Gerrit-PatchSet: 22
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 01:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment