Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46620 )
Change subject: mb/google/poppy/v/atlas: Reset bluetooth during boot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... PS4, Line 198: DEEP
the complication is that i think there's a pull-up on the M.2 module
ACK.
linux expects the device to be out of reset,
Before ACPI scan is done? That doesn't sound right. You should be able to drive the reset line early on using _INI method in ACPI. Anyways, that will need a separate driver of its own in coreboot to generate the ACPI methods. Probably we can think about it as a follow-up.
-
Furquan Shaikh (Code Review)