Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58493 )
Change subject: soc/amd/common/block/cpu/smm/finalize: simplify finalize_cores ......................................................................
soc/amd/common/block/cpu/smm/finalize: simplify finalize_cores
The local variable int r isn't needed, so remove it. This is a preparation to change the return type of mp_run_on_all_cpus from int to enum cb_err which will be done in a follow-up patch.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie4c454cbfcc581be41ea3463ea6f852a72886128 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58493 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/amd/common/block/cpu/smm/finalize.c 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/cpu/smm/finalize.c b/src/soc/amd/common/block/cpu/smm/finalize.c index 2df5524..2795100 100644 --- a/src/soc/amd/common/block/cpu/smm/finalize.c +++ b/src/soc/amd/common/block/cpu/smm/finalize.c @@ -29,11 +29,9 @@
static void finalize_cores(void) { - int r; printk(BIOS_SPEW, "Lock SMM configuration\n");
- r = mp_run_on_all_cpus(per_core_finalize, NULL); - if (r) + if (mp_run_on_all_cpus(per_core_finalize, NULL)) printk(BIOS_WARNING, "Failed to finalize all cores\n"); }
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.