Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb/clevo/tgl-u: add new board L14xMU ......................................................................
Patch Set 14: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59548/comment/c0d4f064_da58bd3c PS14, Line 56: - WLAN/BT (PCIe) - gets detected but can't be enabled Could it be related to rfkill stuff?
File src/mainboard/clevo/tgl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/59548/comment/e37d525d_9d84d7f0 PS13, Line 12: select MAINBOARD_HAS_LPC_TPM What if someone wants to use fTPM?
File src/mainboard/clevo/tgl-u/cmos.layout:
https://review.coreboot.org/c/coreboot/+/59548/comment/690d4341_b0e5682f PS13, Line 20: 400 1 e 2 hyper_threading Doesn't this conflict with century byte?
File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59548/comment/24f001a6_949736d2 PS13, Line 26: DdiPortAConfig Looks like this should use an enum
https://review.coreboot.org/c/coreboot/+/59548/comment/18f99b7e_a7a3ab52 PS13, Line 147: device ref i2c1 on What is this used for?
File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59548/comment/88ea0aae_898eed65 PS14, Line 191: device ref peg on nit: I'd move this before `tbt_pcie_rp0`
-
Angel Pons (Code Review)