Change in coreboot[master]: mb/google/brya: Reset XHCI controller while preparing for S5

[Subrata Banik (Code Review)]

Attention is currently required from: Subrata Banik.
Hello build bot (Jenkins), Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/63552

to look at the new patch set (#2).

Change subject: mb/google/brya: Reset XHCI controller while preparing for S5
......................................................................

mb/google/brya: Reset XHCI controller while preparing for S5

This patch calls into `xhci_host_reset()` function to perform XHCI
controller reset.

Without this patch the PMC IPC timeout issue is seen while sending the
USB-C (0xA7) command during resume from S5 (S5->S4->S3->S0).

On Brya variants, resume from S5 state results in PMC error while
sending PMC IPC (0xA7) to USB-C active ports, log here:

localhost ~ # cbmem -c | grep ERROR

[ERROR]  PMC IPC timeout after 1000 ms
[ERROR]  PMC IPC command 0x200a7 failed
[ERROR]  pmc_send_ipc_cmd failed
[ERROR]  Failed to setup port:0 to initial state
[ERROR]  PMC IPC timeout after 1000 ms
[ERROR]  PMC IPC command 0x200a7 failed
[ERROR]  pmc_send_ipc_cmd failed
[ERROR]  Failed to setup port:1 to initial state
[ERROR]  PMC IPC timeout after 1000 ms
[ERROR]  PMC IPC command 0x20a0 failed

This problem is not seen while resuming from G3 (G3->S5->S4->S3->S0).

Upon resume the state of USB ports are not the same between S5 and G3
and it appears that the active USB port still is in U3 (suspend) while
PMC tries to send the IPC command, finally, results into timeout.

This patch utilises the S5 SMI handler to reset the XHCI controller
using `xhci_host_reset()` prior entering into the S5, it helps to
restore the port state to active hence, no PMC timeout is seen with
this code change.

BUG=b:227289581
TEST=No PMC timeout is observed while sending USB-C PMC command (0xA7)
during resume from S5.

Total Time: 1,045,855
localhost ~ # cbmem -c | grep ERROR

No PMC timeout error is observed with this CL.

Signed-off-by: Subrata Banik 
Change-Id: Ibf06a64f055a0cee3659b410652082f31e18e149
---
M src/mainboard/google/brya/smihandler.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/63552/2