[M] Change in coreboot[main]: soc/amd/glinda/cpu: Compute total L3 cache size

[Naresh Solanki (Code Review)]

Attention is currently required from: Angel Pons, Felix Held.

Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )

Change subject: soc/amd/glinda/cpu: Compute total L3 cache size
......................................................................

Patch Set 9:

(11 comments)

Patchset:

PS9: 
Will rebase on top of CB:85638 (which might have some follow-up changes for Kconfig) & update the current patch with the comments addressed.

Commit Message:

https://review.coreboot.org/c/coreboot/+/85640/comment/1662f42f_263e4b85?usp... :
PS9, Line 22:
> maybe also point out that this also covers the case of l3 cache blocks having different sizes?

Sure.

File src/soc/amd/glinda/cpu.c:

PS9:
> since glinda won't be the only amd soc where this is needed, please consider moving the implementati […]

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/0ac68754_08ace06f?usp... :
PS9, Line 22: get
> i'd use a different word than 'get' here, since my expectation from a function where the name contai […]

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/5e033c05_09c76362?usp... :
PS9, Line 24: 0x8000001e
> CPUID_EBX_CORE_ID

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/da011696_bdc33deb?usp... :
PS9, Line 24: cpuid
> since we only need the data in ebx, i'd use cpuid_ebx instead of cpuid here

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/c6b29ef9_a79978d0?usp... :
PS9, Line 27: 	uint8_t level = 3;
> this could be made const

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/ad211480_82241613?usp... :
PS9, Line 27: 3
> CACHE_L3

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/c5377c7b_713f94d0?usp... :
PS9, Line 38: 3
> CACHE_L3

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/1c668b50_7df0b422?usp... :
PS9, Line 49: 	for (int i = 0; i < get_cpu_count(); i++) {
> a comment on this for loop might make it a bit easier to understand. […]

ack

https://review.coreboot.org/c/coreboot/+/85640/comment/9120518f_53f027d1?usp... :
PS9, Line 59: 	}
> i'd add a newline here

ack