Attention is currently required from: Eric Lai, Matt DeVillier, Nick Vaccaro, Subrata Banik.
David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email )
Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
if this is indeed necessary, then we need to figure out how to exclude these bogus device values fro […]
With this change incorporated, I only see _SB.PCI0.MCHC, and not _SB.PCI0.RP[..].MCHC devices. The device that is missing without this change (on the device I'm testing on, pujjo) is _SB.PCI0.RP01.WF00. I'm fairly new to this, but I ran the following commands:
``` mkdir acpi cd acpi acpidump -b iasl *.dat grep MCHC *dsl ```
And only came out with _SB.PCI0.MCHC in both dsdt and ssdt. Let me know if I missed something. Which table(s) are the _SB.PCI0.RP[..].MCHC devices present in when you're testing?
Effectively, changing WiFi devices from pci to generic results in them being detected as CNVi devices rather than PCIe. This breaks Linux's ability to associate the hardware with an ACPI device presentation and prevents adding additional functionality via new functions in SSDT.