Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50603 )
Change subject: soc/amd/picasso: always include PSP secure OS in amdfw
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50603/comment/b40a9924_91b43ad3
PS1, Line 9: When USE_PSPSECUREOS isn't selected, we get stuck in FSP-S.
Is that by design, or a bug in FSP-S?
in stoneyridge with psp generation 1 that part of amdfw was optional; it's not optional for the psp generation 2 that is used on picasso/cezanne, so without that it'll be operating out of spec; fsp-s is just the place where we probably have an assert for the psp being unhappy about that. so i'm pretty sure that it's not a bug in fsp-s; i am however a bit surprised that it even gets so far without that part of the psp firmware. i don't have much visibility into what the psp wants and does exactly though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60d0e5ab0bd9f4d76cc48d08ca05d27c60e898c4
Gerrit-Change-Number: 50603
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 14 Feb 2021 18:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment