Attention is currently required from: Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/69543/comment/56c2ae2b_4d28fd77
PS2, Line 199: dev_path(dev)
What about synchronizing the message format with the other logs and use #dev->chip_ops->name' instea […]
OK, agreed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment