Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59715 )
Change subject: vc/mediatek/mt8195: Fix rank1 CKE setting for single-rank DRAM ......................................................................
vc/mediatek/mt8195: Fix rank1 CKE setting for single-rank DRAM
Fix the issue that power consumption of single rank DRAM is greater than dual rank DRAM due to incorrect settings of rank1 CKE. Set rank1 CKE to the correct state to fix this issue.
BUG=b:196867407 TEST=DUT can boot to OS.
Signed-off-by: Ryan Chuang ryan.chuang@mediatek.corp-partner.google.com Change-Id: If336197aea4770dda1332b6e83da8ec9a4f9d77b Reviewed-on: https://review.coreboot.org/c/coreboot/+/59715 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c b/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c index e7e8f89..e3baf7b 100644 --- a/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c +++ b/src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c @@ -1946,6 +1946,11 @@ #endif }
+ if (p->support_rank_num == RANK_SINGLE){ + CKEFixOnOff(p, RANK_1, CKE_DYNAMIC, TO_ALL_CHANNEL); + mcSHOW_DBG_MSG(("Set RANK1 CKE to DYNAMIC\n")); + } + #if (FOR_DV_SIMULATION_USED == 0 && SW_CHANGE_FOR_SIMULATION == 0) U32 backup_broadcast; backup_broadcast = GetDramcBroadcast();
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.