[S] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP - coreboot-gerrit

23 Feb 2025


      Attention is currently required from: Qinghong Zeng.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86554?usp=email )
Change subject: mb/google/nissa/var/pujjoniru: Modify the gpio of GPIO_PCH_WP
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/brya/variants/pujjoniru/gpio.c:
https://review.coreboot.org/c/coreboot/+/86554/comment/d3b1db08_85636753?usp... :
PS1, Line 212: DECLARE_CROS_GPIOS(cros_gpios);
...
`adding a line without newline at end of file`
Please fix.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86554?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic92ff33a5fde50a1a400043b2daba0414eb9e255
Gerrit-Change-Number: 86554
Gerrit-PatchSet: 2
Gerrit-Owner: hualin wei weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Qinghong Zeng zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Qinghong Zeng zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 00:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No