Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [WIP]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
[WIP]drivers: Get rid of set_vbe_mode_info_valid
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 21 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/1
diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c index fed7754..2fa1a58 100644 --- a/src/drivers/aspeed/common/ast_mode_corebootfb.c +++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c @@ -221,7 +221,7 @@ return ret; }
- /* Updated edid for set_vbe_mode_info_valid */ + /* Updated edid for fb_fill_framebuffer_info */ edid.x_resolution = edid.mode.ha; edid.y_resolution = edid.mode.va; edid.framebuffer_bits_per_pixel = format.cpp[0] * 8; diff --git a/src/include/edid.h b/src/include/edid.h index 7c3e9c8..f61a71e 100644 --- a/src/include/edid.h +++ b/src/include/edid.h @@ -109,8 +109,6 @@ int decode_edid(unsigned char *edid, int size, struct edid *out); void edid_set_framebuffer_bits_per_pixel(struct edid *edid, int fb_bpp, int row_byte_alignment); -struct edid_fb_info *set_vbe_mode_info_valid(const struct edid *edid, uintptr_t fb_addr); -void set_vbe_framebuffer_orientation(enum lb_fb_orientation orientation); int set_display_mode(struct edid *edid, enum edid_modes mode);
#endif /* EDID_H */ diff --git a/src/include/framebuffer_info.h b/src/include/framebuffer_info.h index 6d2f9a6..a2f2b39 100644 --- a/src/include/framebuffer_info.h +++ b/src/include/framebuffer_info.h @@ -42,4 +42,7 @@ void fb_fill_framebuffer_set_orientation(struct edid_fb_info *info, enum lb_fb_orientation orientation);
+struct edid_fb_info *fb_new_framebuffer_info_from_edid(const struct edid *edid, + uintptr_t fb_addr); + #endif /* __FRAMEBUFFER_INFO_H_ */ diff --git a/src/lib/edid_fill_fb.c b/src/lib/edid_fill_fb.c index 1928335..d387802 100644 --- a/src/lib/edid_fill_fb.c +++ b/src/lib/edid_fill_fb.c @@ -139,7 +139,8 @@ /* * Take an edid, and create a framebuffer. Set fb_valid to 1. */ -struct edid_fb_info *set_vbe_mode_info_valid(const struct edid *edid, uintptr_t fb_addr) +struct edid_fb_info *fb_new_framebuffer_info_from_edid(const struct edid *edid, + uintptr_t fb_addr) { struct edid_fb_info *info = fb_new_framebuffer_info(); if (!info) diff --git a/src/mainboard/google/daisy/mainboard.c b/src/mainboard/google/daisy/mainboard.c index 30f8805..0d50953 100644 --- a/src/mainboard/google/daisy/mainboard.c +++ b/src/mainboard/google/daisy/mainboard.c @@ -32,6 +32,7 @@ #include <soc/usb.h> #include <symbols.h> #include <vbe.h> +#include <framebuffer_info.h>
#include "exynos5250.h"
@@ -277,7 +278,7 @@
sdmmc_vdd();
- set_vbe_mode_info_valid(&edid, (uintptr_t)fb_addr); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)fb_addr);
lcd_vdd();
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 57014b4..8b4668e 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -173,7 +173,7 @@ return false; } mtk_ddp_mode_set(edid); - struct edid_fb_info *info = set_vbe_mode_info_valid(edid, 0); + struct edid_fb_info *info = fb_new_framebuffer_info_from_edid(edid, 0); if (info) fb_fill_framebuffer_set_orientation(info, panel->s->orientation);
diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c index 421826c..cc583fe 100644 --- a/src/mainboard/google/oak/mainboard.c +++ b/src/mainboard/google/oak/mainboard.c @@ -32,6 +32,7 @@ #include <soc/pll.h> #include <soc/usb.h> #include <vendorcode/google/chromeos/chromeos.h> +#include <framebuffer_info.h>
enum { CODEC_I2C_BUS = 0, @@ -238,7 +239,7 @@ }
mtk_ddp_mode_set(&edid); - set_vbe_mode_info_valid(&edid, (uintptr_t)0); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)0); }
static void mainboard_init(struct device *dev) diff --git a/src/mainboard/google/peach_pit/mainboard.c b/src/mainboard/google/peach_pit/mainboard.c index 553c2ad..40947e2 100644 --- a/src/mainboard/google/peach_pit/mainboard.c +++ b/src/mainboard/google/peach_pit/mainboard.c @@ -36,6 +36,7 @@ #include <string.h> #include <symbols.h> #include <vbe.h> +#include <framebuffer_info.h>
/* convenient shorthand (in MB) */ #define DRAM_START ((uintptr_t)_dram/MiB) @@ -416,7 +417,7 @@
sdmmc_vdd();
- set_vbe_mode_info_valid(&edid, (uintptr_t)fb_addr); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)fb_addr);
/* * The reset value for FIMD SYSMMU register MMU_CTRL:0x14640000 diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 98e30e7..eff0b9b 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -34,6 +34,7 @@ #include <cbmem.h> #include <southbridge/intel/i82801gx/nvs.h> #include <types.h> +#include <framebuffer_info.h>
#include "i945.h" #include "chip.h" @@ -386,7 +387,7 @@ (void *)pgfx, hactive * vactive * 4); memset((void *)pgfx, 0x00, hactive * vactive * 4);
- set_vbe_mode_info_valid(&edid, pgfx); + fb_new_framebuffer_info_from_edid(&edid, pgfx); } else { vga_misc_write(0x67);
diff --git a/src/soc/nvidia/tegra124/display.c b/src/soc/nvidia/tegra124/display.c index 6fa3bdf..e4fd183 100644 --- a/src/soc/nvidia/tegra124/display.c +++ b/src/soc/nvidia/tegra124/display.c @@ -27,6 +27,7 @@ #include <soc/nvidia/tegra/pwm.h> #include <stdint.h> #include <string.h> +#include <framebuffer_info.h>
#include "chip.h"
@@ -330,5 +331,5 @@ edid.mode.ha = config->xres; edid_set_framebuffer_bits_per_pixel(&edid, config->framebuffer_bits_per_pixel, 32); - set_vbe_mode_info_valid(&edid, (uintptr_t)(framebuffer_base_mb*MiB)); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)(framebuffer_base_mb*MiB)); } diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index a66b2d4..fd85f8f 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -31,6 +31,7 @@ #include <soc/grf.h> #include <soc/soc.h> #include <soc/vop.h> +#include <framebuffer_info.h>
#include "chip.h"
@@ -138,5 +139,5 @@ break; }
- set_vbe_mode_info_valid(&edid, (uintptr_t)lcdbase); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)lcdbase); } diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index 9cd4053..f76fe22 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -32,6 +32,7 @@ #include <soc/mipi.h> #include <soc/soc.h> #include <soc/vop.h> +#include <framebuffer_info.h>
#include "chip.h"
@@ -174,7 +175,7 @@ break; } mainboard_power_on_backlight(); - set_vbe_mode_info_valid(&edid, (uintptr_t)0); + fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)0);
return; }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [WIP]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/1/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/1/src/include/framebuffer_inf... PS1, Line 46: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/1/src/include/framebuffer_inf... PS1, Line 46: uintptr_t fb_addr); please, no spaces at the start of a line
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#2).
Change subject: [WIP]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
[WIP]drivers: Get rid of set_vbe_mode_info_valid
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [WIP]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/2/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/2/src/include/framebuffer_inf... PS2, Line 50: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/2/src/include/framebuffer_inf... PS2, Line 50: uintptr_t fb_addr); please, no spaces at the start of a line
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#3).
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
[TESTME]drivers: Get rid of set_vbe_mode_info_valid
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/3/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/3/src/include/framebuffer_inf... PS3, Line 50: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/3/src/include/framebuffer_inf... PS3, Line 50: uintptr_t fb_addr); please, no spaces at the start of a line
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#4).
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
[TESTME]drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/4/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/4/src/include/framebuffer_inf... PS4, Line 50: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/4/src/include/framebuffer_inf... PS4, Line 50: uintptr_t fb_addr); please, no spaces at the start of a line
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#5).
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
[TESTME]drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 22 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/5
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: [TESTME]drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/5/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/5/src/include/framebuffer_inf... PS5, Line 51: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/5/src/include/framebuffer_inf... PS5, Line 51: uintptr_t fb_addr); please, no spaces at the start of a line
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#6).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Tested on: * QEMU VGA cirrus * QEMU VGA bochs * Aspeed AST2500 NGI * Lenovo X220 using libgfxinit * Intel FSP2.0 GOP
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 22 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 51: uintptr_t fb_addr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 51: uintptr_t fb_addr); please, no spaces at the start of a line
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 7: Code-Review+1
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 49: struct edid; Should include <edid.h> instead?
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
PS7: Should this file still be called edid_fill_lb.c? Sounds more like a framebuffer_info.c to me by now...
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c@162 PS7, Line 162: fb_new_framebuffer_info_from_edid Shouldn't this be called fb_set_framebuffer_info_from_edid(), since it's the equivalent of fb_set_framebuffer_info() (not of fb_new_framebuffer_info())?
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#8).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 22 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/8
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... File src/mainboard/google/daisy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... PS8, Line 34: #include <framebuffer_info.h> Please sort new headers in alphabetically, at least in files that are already doing that.
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#9).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/mainboard/google/peach_pit/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 12 files changed, 23 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/9
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#10).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/nvidia/tegra124/display.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 10 files changed, 21 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/10
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment); Shouldn't we get rid of this too? I think this was only used to set bytes_per_line.
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#11).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/11
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment);
Shouldn't we get rid of this too? I think this was only used to set bytes_per_line.
With this series only some ARM drivers seem to make use of it. Please have a look if it can easily be dropped and the calculations can be moved to the driver.
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
PS7:
Should this file still be called edid_fill_lb.c? Sounds more like a framebuffer_info.c to me by now. […]
Done
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c@162 PS7, Line 162: fb_new_framebuffer_info_from_edid
Shouldn't this be called fb_set_framebuffer_info_from_edid(), since it's the equivalent of fb_set_fr […]
Done
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#12).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/12
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#13).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/13
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment);
With this series only some ARM drivers seem to make use of it. […]
Yes, you can remove all of those as long as you pass the correct row_alignment instead.
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#14).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/14
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#15).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/15
Hello build bot (Jenkins), Frans Hendriks, Julius Werner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39006
to look at the new patch set (#16).
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics driver into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics driver can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple indepent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independend of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/16
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment);
Yes, you can remove all of those as long as you pass the correct row_alignment instead.
Anything to do here? Could it be done in a follow-up?
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39006/7/src/include/framebuffer_inf... PS7, Line 49: struct edid;
Should include <edid. […]
Done
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... File src/mainboard/google/daisy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39006/8/src/mainboard/google/daisy/... PS8, Line 34: #include <framebuffer_info.h>
Please sort new headers in alphabetically, at least in files that are already doing that.
Done
Angel Pons has uploaded a new patch set (#20) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics drivers into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics drivers can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple independent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independent of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/20
Angel Pons has uploaded a new patch set (#21) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
drivers: Get rid of set_vbe_mode_info_valid
Currently it's not possible to add multiple graphics drivers into one coreboot image. This patch series will fix this issue by providing a single API that multiple graphics drivers can use.
This is required for platforms that have two graphic cards, but different graphic drivers, like Intel+Aspeed on server platforms or Intel+Nvidia on consumer notebooks.
The goal is to remove duplicated fill_fb_framebuffer(), the advertisment of multiple independent framebuffers in coreboot tables, and better runtime/build time graphic configuration options.
Replace set_vbe_mode_info_valid with fb_new_framebuffer_info_from_edid and migrate to new header, that's independent of VBE.
Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/include/edid.h M src/include/framebuffer_info.h M src/lib/edid_fill_fb.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/mainboard.c M src/northbridge/intel/i945/gma.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3399/display.c 9 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/39006/21
Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Abandoned
merged into CB:39004
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Frans Hendriks (Code Review)
-
Julius Werner (Code Review)
-
Patrick Rudolph (Code Review)