Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner, Aaron Durbin, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49468 )
Change subject: vboot: fix CBFS MCACHE on zork
......................................................................
Patch Set 3:
(1 comment)
File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/c/coreboot/+/49468/comment/01cb5efb_ff1adb87
PS2, Line 32: const struct cbfs_boot_device *cbd = cbfs_get_boot_device(false);
You can't just change this, this is not correct. […]
Updated CL to reflect bug comments. PTAL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49468
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c5f8474600a06e3a08358733a38f70787e944a
Gerrit-Change-Number: 49468
Gerrit-PatchSet: 3
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 18 Jan 2021 05:55:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment